Fix bugs detected by static analyzer

Change-Id: I18071710dbbeff61ca2f1ab38c25b5faeaebaf6b
Signed-off-by: Yu jiung <jiung.yu@samsung.com>

diff --git a/packaging/wifi-direct-manager.spec b/packaging/wifi-direct-manager.spec
index 48950a7..1457b33 100644 (file)
--- a/packaging/wifi-direct-manager.spec
+++ b/packaging/wifi-direct-manager.spec
@@ -6,7 +6,7 @@
 
 Name:          wifi-direct-manager
 Summary:       Wi-Fi Direct manger
-Version:       1.2.247
+Version:       1.2.248
 Release:       1
 Group:      Network & Connectivity/Wireless
 License:    Apache-2.0

diff --git a/plugin/wpasupplicant/ctrl_iface_dbus/wfd-plugin-wpasupplicant.c b/plugin/wpasupplicant/ctrl_iface_dbus/wfd-plugin-wpasupplicant.c
index d21a0f6..3698c84 100644 (file)
--- a/plugin/wpasupplicant/ctrl_iface_dbus/wfd-plugin-wpasupplicant.c
+++ b/plugin/wpasupplicant/ctrl_iface_dbus/wfd-plugin-wpasupplicant.c
@@ -1008,6 +1008,7 @@ static void __ws_parse_peer_joined(char *peer_path,
        __WDP_LOG_FUNC_ENTER__;
 
        GVariantIter *iter;
+       gboolean iter_res = TRUE;
        static unsigned char peer_dev[WS_MACSTR_LEN] = {'\0',};
        const char *path = NULL;
        char *loc = NULL;
@@ -1022,8 +1023,8 @@ static void __ws_parse_peer_joined(char *peer_path,
                __ws_mac_compact_to_normal(loc + 1, peer_dev);
        __ws_txt_to_mac(peer_dev, dev_addr);
        WDP_LOGD("peer mac [" MACSTR "]", MAC2STR(dev_addr));
-       for (i = 0; i < OEM_IPADDR_LEN; i++)
-               g_variant_iter_loop(iter, "y", &ip_addr[i]);
+       for (i = 0; iter_res &&  i < OEM_IPADDR_LEN; i++)
+               iter_res = g_variant_iter_loop(iter, "y", &ip_addr[i]);
        g_variant_iter_free(iter);
 
        WDP_LOGD("peer ip [" IPSTR "]", IP2STR(ip_addr));