Improve Math.DivRem performance

Until the JIT is able to eliminate one of the two idiv operations, using a multiplication and subtraction is measurably faster than an extra division.

Commit migrated from https://github.com/dotnet/coreclr/commit/bd1f21d17c439481d7bc2a5219779e2474419a96

diff --git a/src/coreclr/src/mscorlib/src/System/Math.cs b/src/coreclr/src/mscorlib/src/System/Math.cs
index cf2b0ee..9ff0a9f 100644 (file)
--- a/src/coreclr/src/mscorlib/src/System/Math.cs
+++ b/src/coreclr/src/mscorlib/src/System/Math.cs
@@ -726,13 +726,21 @@ namespace System {
         }
 
         public static int DivRem(int a, int b, out int result) {
-            result =  a%b;
-            return a/b;
+            // TODO https://github.com/dotnet/coreclr/issues/3439:
+            // Restore to using % and / when the JIT is able to eliminate one of the idivs.
+            // In the meantime, a * and - is measurably faster than an extra /.
+            int div = a / b;
+            result = a - (div * b);
+            return div;
         }
 
         public static long DivRem(long a, long b, out long result) {
-            result =  a%b;
-            return a/b;
+            // TODO https://github.com/dotnet/coreclr/issues/3439:
+            // Restore to using % and / when the JIT is able to eliminate one of the idivs.
+            // In the meantime, a * and - is measurably faster than an extra /.
+            long div = a / b;
+            result = a - (div * b);
+            return div;
         }
     }
 }