rxrpc: Fix uninitialised variable warning
authorDavid Howells <dhowells@redhat.com>
Fri, 2 Sep 2016 21:39:44 +0000 (22:39 +0100)
committerDavid Howells <dhowells@redhat.com>
Fri, 2 Sep 2016 21:39:44 +0000 (22:39 +0100)
Fix the following uninitialised variable warning:

../net/rxrpc/call_event.c: In function 'rxrpc_process_call':
../net/rxrpc/call_event.c:879:58: warning: 'error' may be used uninitialized in this function [-Wmaybe-uninitialized]
    _debug("post net error %d", error);
                                                          ^

Signed-off-by: David Howells <dhowells@redhat.com>
net/rxrpc/call_event.c

index de72de6..4754c7f 100644 (file)
@@ -868,7 +868,6 @@ skip_msg_init:
        /* deal with events of a final nature */
        if (test_bit(RXRPC_CALL_EV_RCVD_ERROR, &call->events)) {
                enum rxrpc_skb_mark mark;
-               int error;
 
                clear_bit(RXRPC_CALL_EV_CONN_ABORT, &call->events);
                clear_bit(RXRPC_CALL_EV_REJECT_BUSY, &call->events);
@@ -876,10 +875,10 @@ skip_msg_init:
 
                if (call->completion == RXRPC_CALL_NETWORK_ERROR) {
                        mark = RXRPC_SKB_MARK_NET_ERROR;
-                       _debug("post net error %d", error);
+                       _debug("post net error %d", call->error);
                } else {
                        mark = RXRPC_SKB_MARK_LOCAL_ERROR;
-                       _debug("post net local error %d", error);
+                       _debug("post net local error %d", call->error);
                }
 
                if (rxrpc_post_message(call, mark, call->error, true) < 0)