media: exynos4-is: Fix runtime PM imbalance in isp_video_open
authorDinghao Liu <dinghao.liu@zju.edu.cn>
Sun, 24 May 2020 03:34:04 +0000 (05:34 +0200)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Tue, 23 Jun 2020 11:20:34 +0000 (13:20 +0200)
pm_runtime_get_sync() increments the runtime PM usage counter even
when it returns an error code. Thus a pairing decrement is needed on
the error handling path to keep the counter balanced.

Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Reviewed-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/platform/exynos4-is/fimc-isp-video.c

index 15f443fa7208226f34c10cdc74723aa21ed372c6..612b9872afc87199870bb2660da83b7922d1a686 100644 (file)
@@ -293,6 +293,7 @@ static int isp_video_open(struct file *file)
        if (!ret)
                goto unlock;
 rel_fh:
+       pm_runtime_put_noidle(&isp->pdev->dev);
        v4l2_fh_release(file);
 unlock:
        mutex_unlock(&isp->video_lock);