sparc: vio: use put_device() instead of kfree()
authorArvind Yadav <arvind.yadav.cs@gmail.com>
Wed, 25 Apr 2018 14:56:14 +0000 (20:26 +0530)
committerDavid S. Miller <davem@davemloft.net>
Mon, 30 Apr 2018 20:09:34 +0000 (16:09 -0400)
Never directly free @dev after calling device_register(), even
if it returned an error. Always use put_device() to give up the
reference initialized.

Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
arch/sparc/kernel/vio.c

index 1a0fa10..32bae68 100644 (file)
@@ -403,7 +403,7 @@ static struct vio_dev *vio_create_one(struct mdesc_handle *hp, u64 mp,
        if (err) {
                printk(KERN_ERR "VIO: Could not register device %s, err=%d\n",
                       dev_name(&vdev->dev), err);
-               kfree(vdev);
+               put_device(&vdev->dev);
                return NULL;
        }
        if (vdev->dp)