misc: mdbg: remove build warnings 56/164956/1
authorSeung-Woo Kim <sw0312.kim@samsung.com>
Fri, 22 Dec 2017 04:37:18 +0000 (13:37 +0900)
committerSeung-Woo Kim <sw0312.kim@samsung.com>
Fri, 22 Dec 2017 04:37:20 +0000 (13:37 +0900)
Remove build warnings in sprd mdbg misc driver.

Change-Id: Ic2a06079da18f04252eeea8005e2ec6088de5c6a
Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>
drivers/misc/mdbg/mdbg.c
drivers/misc/mdbg/mdbg_ring.c
drivers/misc/mdbg/mdbg_sdio.c

index 2c81d9c..011f9dd 100755 (executable)
@@ -67,7 +67,7 @@ void mdbg_assert_read(void)
                MDBG_ERR( "The assert data len:%d, beyond max read:%d",read_len,MDBG_ASSERT_SIZE);
 
        sdio_dev_read(MDBG_CHANNEL_ASSERT,mdbg_proc->assert.buf,&read_len);
-       printk(KERN_INFO "mdbg_assert_read:%s\n",mdbg_proc->assert.buf);
+       printk(KERN_INFO "mdbg_assert_read:%s\n", (char *)mdbg_proc->assert.buf);
        mdbg_proc->assert.rcv_len = read_len;
        complete(&mdbg_proc->assert.completed);
        wake_up_interruptible(&mdbg_proc->assert.rxwait);
@@ -88,7 +88,7 @@ void mdbg_wdtirq_read(void)
                MDBG_ERR( "The assert data len:%d, beyond max read:%d",read_len,MDBG_WDTIRQ_SIZE);
 
        sdio_dev_read(MDBG_CHANNEL_WDTIRQ,mdbg_proc->wdtirq.buf,&read_len);
-       printk(KERN_INFO "mdbg_wdtirq_read:%s\n",mdbg_proc->wdtirq.buf);
+       printk(KERN_INFO "mdbg_wdtirq_read:%s\n", (char *)mdbg_proc->wdtirq.buf);
        mdbg_proc->wdtirq.rcv_len = read_len;
        complete(&mdbg_proc->wdtirq.completed);
        wake_up_interruptible(&mdbg_proc->wdtirq.rxwait);
@@ -99,7 +99,7 @@ EXPORT_SYMBOL_GPL(mdbg_wdtirq_read);
 
 void mdbg_loopcheck_read(void)
 {
-       int read_len;
+       unsigned int read_len;
 
        read_len = sdio_dev_get_chn_datalen(MDBG_CHANNEL_LOOPCHECK);
        if(read_len <= 0){
@@ -110,7 +110,7 @@ void mdbg_loopcheck_read(void)
                MDBG_ERR( "The loopcheck data len:%d, beyond max read:%d",read_len,MDBG_LOOPCHECK_SIZE);
 
        sdio_dev_read(MDBG_CHANNEL_LOOPCHECK,mdbg_proc->loopcheck.buf,&read_len);
-       printk(KERN_INFO "mdbg_loopcheck_read:%s\n",mdbg_proc->loopcheck.buf);
+       printk(KERN_INFO "mdbg_loopcheck_read:%s\n", (char *)mdbg_proc->loopcheck.buf);
        mdbg_proc->loopcheck.rcv_len = read_len;
        complete(&mdbg_proc->loopcheck.completed);
 
@@ -133,7 +133,7 @@ void mdbg_at_cmd_read(void)
 
        sdio_dev_read(MDBG_CHANNEL_AT_CMD,mdbg_proc->at_cmd.buf,&read_len);
        mdbg_proc->at_cmd.rcv_len = read_len;
-       printk(KERN_INFO "mdbg_at_cmd_read:%s\n",mdbg_proc->at_cmd.buf);
+       printk(KERN_INFO "mdbg_at_cmd_read:%s\n", (char *)mdbg_proc->at_cmd.buf);
        complete(&mdbg_proc->at_cmd.completed);
 
        return;
@@ -143,20 +143,24 @@ EXPORT_SYMBOL_GPL(mdbg_at_cmd_read);
 static int mdbg_proc_open(struct inode *inode, struct file *filp)
 {
        struct mdbg_proc_entry *entry = (struct mdbg_proc_entry *)PDE_DATA(inode);
+#if 0
        char *type = entry->name;
 
-       filp->private_data = entry;
        //MDBG_ERR("%s type:%s\n",__func__,type);
+#endif
+       filp->private_data = entry;
 
        return 0;
 }
 
 static int mdbg_proc_release(struct inode *inode, struct file *filp)
 {
+#if 0
        struct mdbg_proc_entry *entry = (struct mdbg_proc_entry *)PDE_DATA(inode);
        char *type = entry->name;
 
        //MDBG_ERR("%s type:%s\n",__func__,type);
+#endif
 
        return 0;
 }
@@ -425,7 +429,7 @@ LOCAL void mdbg_fs_init_exit(void)
 
 LOCAL ssize_t mdbg_read(struct file *filp,char __user *buf,size_t count,loff_t *pos)
 {
-       MDBG_SIZE_T read_size;;
+       MDBG_SIZE_T read_size;
        int timeout = -1;
        int rval;
 
@@ -455,7 +459,7 @@ LOCAL ssize_t mdbg_read(struct file *filp,char __user *buf,size_t count,loff_t *
        }
 
        read_size = mdbg_receive(mdbg_dev->read_buf , MDBG_MAX_BUFFER_LEN);
-       printk_ratelimited(KERN_INFO "%s read_size: %d mdbg_read_count:%d\n",__func__,read_size,mdbg_read_count);
+       printk_ratelimited(KERN_INFO "%s read_size: %lu mdbg_read_count:%u\n",__func__,read_size,mdbg_read_count);
 
        if((read_size > 0) && (read_size <= MDBG_MAX_BUFFER_LEN)){
                MDBG_LOG("Show %d bytes data.",read_size);
index 6957694..c15b9ab 100755 (executable)
@@ -35,7 +35,7 @@ PUBLIC MDBG_RING_T* mdbg_ring(MDBG_SIZE_T size)
        MDBG_RING_T* pRing = NULL;
        do{
                if(size < MDBG_RING_MIN_SIZE){
-                       MDBG_ERR("size error:%d",size);
+                       MDBG_ERR("size error:%lu",size);
                        break;
                }
                pRing = kmalloc(sizeof(MDBG_RING_T),GFP_KERNEL);
index 1cf9127..fe4e41f 100755 (executable)
@@ -113,18 +113,21 @@ LOCAL MDBG_SIZE_T mdbg_sdio_write(char* buff, MDBG_SIZE_T len,uint32 chn)
 
 PUBLIC void mdbg_sdio_read(void)
 {
+       unsigned int read_len;
+
        wake_lock(&mdbg_wake_lock);
        mutex_lock(&mdbg_read_mutex);
        //set_marlin_wakeup(MDBG_CHANNEL_READ,0x1);
        sdio_read_len = sdio_dev_get_chn_datalen(MDBG_CHANNEL_READ);
        if(sdio_read_len <= 0)
        {
-               MDBG_ERR("[%s][%d]\n",__func__, sdio_read_len);
+               MDBG_ERR("[%s][%lu]\n",__func__, sdio_read_len);
                wake_unlock(&mdbg_wake_lock);
                mutex_unlock(&mdbg_read_mutex);
                return;
        }
-       sdio_dev_read(MDBG_CHANNEL_READ,mdbg_rx_buff,&sdio_read_len);
+       sdio_dev_read(MDBG_CHANNEL_READ,mdbg_rx_buff,&read_len);
+       sdio_read_len = (MDBG_SIZE_T)read_len;
        sdio_read_len = mdbg_ring_write(rx_ring,mdbg_rx_buff, sdio_read_len);
        mdbg_read_count += sdio_read_len;
        wake_up_interruptible(&mdbg_wait);