tests: unittest: Rename unitttest name to hal-api-common-unittest 65/276565/1 accepted/tizen/unified/20220622.215415 submit/tizen/20220622.061839
authorChanwoo Choi <cw00.choi@samsung.com>
Thu, 16 Jun 2022 03:12:51 +0000 (12:12 +0900)
committerChanwoo Choi <cw00.choi@samsung.com>
Tue, 21 Jun 2022 01:49:52 +0000 (10:49 +0900)
hal-api-common is the official module name. In order to improve
the readability of unittest name, rename to hal-api-common-unittest
as following:
- common-unittest -> hal-api-common-unittest
- CommonHaltest -> HalApiCommonTest

Change-Id: I9a3e1667b76b9fab361fddca3cb052389526f581
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
tests/unittest/CMakeLists.txt
tests/unittest/test-hal-api-common.cc

index 2ff5c7e..90dff51 100644 (file)
@@ -1,28 +1,28 @@
 ENABLE_TESTING()
-SET(HAL_COMMON_UNITTEST "common-unittest")
+SET(HAL_API_COMMON_UNITTEST "hal-api-common-unittest")
 
 SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -g -Wall -Werror")
 SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${EXTRA_CFLAGS} -std=c++14 -Wall -Werror")
 
 AUX_SOURCE_DIRECTORY(${CMAKE_CURRENT_SOURCE_DIR}/ UNITTEST_SRCS)
-ADD_EXECUTABLE(${HAL_COMMON_UNITTEST} ${UNITTEST_SRCS})
+ADD_EXECUTABLE(${HAL_API_COMMON_UNITTEST} ${UNITTEST_SRCS})
 
-TARGET_INCLUDE_DIRECTORIES(${HAL_COMMON_UNITTEST} PUBLIC
+TARGET_INCLUDE_DIRECTORIES(${HAL_API_COMMON_UNITTEST} PUBLIC
        "${CMAKE_CURRENT_SOURCE_DIR}/../../include"
 )
 
 INCLUDE(FindPkgConfig)
-pkg_check_modules(hal_common_unittest_pkgs REQUIRED gmock)
+pkg_check_modules(hal_api_common_unittest_pkgs REQUIRED gmock)
 
-FOREACH(flag ${hal_common_unittest_pkgs_CFLAGS})
+FOREACH(flag ${hal_api_common_unittest_pkgs_CFLAGS})
        SET(EXTRA_CFLAGS "${EXTRA_CFLAGS} ${flag}")
 ENDFOREACH(flag)
 
-TARGET_LINK_LIBRARIES(${HAL_COMMON_UNITTEST} ${hal_common_unittest_pkgs_LDFLAGS} ${PROJECT_NAME})
-SET_TARGET_PROPERTIES(${HAL_COMMON_UNITTEST} PROPERTIES COMPILE_FLAGS "-fPIE -fvisibility=default")
-SET_TARGET_PROPERTIES(${HAL_COMMON_UNITTEST} PROPERTIES LINK_FLAGS "-pie")
+TARGET_LINK_LIBRARIES(${HAL_API_COMMON_UNITTEST} ${hal_api_common_unittest_pkgs_LDFLAGS} ${PROJECT_NAME})
+SET_TARGET_PROPERTIES(${HAL_API_COMMON_UNITTEST} PROPERTIES COMPILE_FLAGS "-fPIE -fvisibility=default")
+SET_TARGET_PROPERTIES(${HAL_API_COMMON_UNITTEST} PROPERTIES LINK_FLAGS "-pie")
 
 ADD_TEST(
-       NAME ${HAL_COMMON_UNITTEST}
-       COMMAND ${HAL_COMMON_UNITTEST}
+       NAME ${HAL_API_COMMON_UNITTEST}
+       COMMAND ${HAL_API_COMMON_UNITTEST}
 )
index acc07eb..8b1e08a 100644 (file)
 
 using namespace std;
 
-class CommonHaltest : public testing::Test {
+class HalApiCommonTest : public testing::Test {
        public:
-               CommonHaltest() {}
-               virtual ~CommonHaltest() {}
+               HalApiCommonTest() {}
+               virtual ~HalApiCommonTest() {}
                virtual void SetUp() {}
                virtual void TearDown() {}
 };
 
-TEST(CommonHaltest, test_symbol_name_invalid_module) {
+TEST(HalApiCommonTest, test_symbol_name_invalid_module) {
        char ret_unknown[MAX_BUFF] = {0, };
        char ret_end[MAX_BUFF] = {0, };
        int ret;
@@ -52,7 +52,7 @@ TEST(CommonHaltest, test_symbol_name_invalid_module) {
        EXPECT_TRUE(ret != TIZEN_ERROR_NONE);
 }
 
-TEST(CommonHaltest, test_check_backend_abi_version_invalid_parameter) {
+TEST(HalApiCommonTest, test_check_backend_abi_version_invalid_parameter) {
        int ret;
 
        ret = hal_common_check_backend_abi_version(HAL_MODULE_UNKNOWN, HAL_ABI_VERSION_TIZEN_7_0);
@@ -68,7 +68,7 @@ TEST(CommonHaltest, test_check_backend_abi_version_invalid_parameter) {
        EXPECT_EQ(ret, TIZEN_ERROR_INVALID_PARAMETER);
 }
 
-TEST(CommonHaltest, get_backend_library_name_unknown) {
+TEST(HalApiCommonTest, get_backend_library_name_unknown) {
        char ret_name[MAX_BUFF] = {0, };
        int ret = hal_common_get_backend_library_name(HAL_MODULE_UNKNOWN, ret_name, MAX_BUFF);
        EXPECT_TRUE(ret != TIZEN_ERROR_NONE);
@@ -101,7 +101,7 @@ class HalInfo {
 
 class HalInfoMatchedTest : public ::testing::TestWithParam<HalInfo> {};
 
-INSTANTIATE_TEST_CASE_P(CommonHaltest,
+INSTANTIATE_TEST_CASE_P(HalApiCommonTest,
        HalInfoMatchedTest,
        ::testing::Values(
        HalInfo(HAL_MODULE_TBM,