[lldb] Improve error message when running static initializers in an expression fails
authorRaphael Isemann <teemperor@gmail.com>
Fri, 7 Feb 2020 12:24:56 +0000 (13:24 +0100)
committerRaphael Isemann <teemperor@gmail.com>
Fri, 7 Feb 2020 12:46:28 +0000 (13:46 +0100)
lldb/packages/Python/lldbsuite/test/commands/expression/static-initializers/TestStaticInitializers.py
lldb/source/Plugins/ExpressionParser/Clang/ClangUserExpression.cpp

index cec0e50..6abdb22 100644 (file)
@@ -30,4 +30,4 @@ class StaticInitializers(TestBase):
 
         # FIXME: This error message is not even remotely helpful.
         self.expect("expr -p -- struct Foo2 { Foo2() { do_abort(); } }; Foo2 f;", error=True,
-                    substrs=["error: couldn't run static initializers: couldn't run static initializer:"])
+                    substrs=["error: couldn't run static initializer:"])
index 1bdc0d1..6d78193 100644 (file)
@@ -659,7 +659,7 @@ bool ClangUserExpression::Parse(DiagnosticManager &diagnostic_manager,
       const char *error_cstr = static_init_error.AsCString();
       if (error_cstr && error_cstr[0])
         diagnostic_manager.Printf(eDiagnosticSeverityError,
-                                  "couldn't run static initializers: %s\n",
+                                  "%s\n",
                                   error_cstr);
       else
         diagnostic_manager.PutString(eDiagnosticSeverityError,