Pylint for job_submitobs.py

C:543,0: Line too long (83/80)
C:294,8:check_sync_pattern: Invalid name "p" (should match [a-z_][a-z0-9_]{2,30}$)

Change-Id: If1ce83ae16bb4bc18b28bfca42b27d2c4616c510

diff --git a/job_submitobs.py b/job_submitobs.py
index da16206..617ecd3 100755 (executable)
--- a/job_submitobs.py
+++ b/job_submitobs.py
@@ -20,7 +20,7 @@ from common import utils
 from common.git import Git, clone_gitproject
 from common import obspkg
 from common import mapping
-from common.gerrit import Gerrit, get_gerrit_event, GerritError
+from common.gerrit import Gerrit, get_gerrit_event, GerritError, is_ref_deleted
 from common.send_mail import prepare_mail
 from common.buildservice import BuildService
 
@@ -185,15 +185,6 @@ def check_tag_format(git, mygerrit, event, tag):
 
     return True
 
-def is_tag_deleted(oldrev, newrev):
-    """check whehter tag is deleted"""
-
-    # 0000*0 is a special git hash code in gerrit for deleted git object
-    if oldrev != newrev and newrev == '0'*40:
-        return True
-    else:
-        return False
-
 def find_specfile(prj_dir, packaging_dir, tag, event, tagger, pkg_name = None):
     """search specfile under packaging directory"""
 
@@ -292,9 +283,9 @@ def check_sync_pattern(event, pattern_str):
     Return: True if need, False otherwise.
     """
     pattern = ast.literal_eval(pattern_str)
-    for p in pattern:
-        if re.match(p['project'], event['project']) and \
-            re.match(p['refname'], event['refname']):
+    for item in pattern:
+        if re.match(item['project'], event['project']) and \
+            re.match(item['refname'], event['refname']):
             return True
 
     return False
@@ -386,7 +377,7 @@ def main():
         print '\nREFNAME "%s" isn\'t start with refs/tags/submit, exit now'\
               % event['refname']
         return 0
-    elif is_tag_deleted(event['oldrev'], event['newrev']):
+    elif is_ref_deleted(event['oldrev'], event['newrev']):
         print '\nREFNAME "%s" is deleted, exit now' % event['refname']
         return 0
 
@@ -553,7 +544,8 @@ def main():
             comment = 'This commit has been submitted to OBS %s project.\n' \
                     % obs_dst_prj + comment
         try:
-            mygerrit.review(commit = event['patchset_revision'], message = comment)
+            mygerrit.review(commit = event['patchset_revision'],
+                    message = comment)
         except GerritError, err:
             print >> sys.stderr, 'Error posting review comment '\
                                  'back to Gerrit: %s' % str(err)