There is no reason to restrict nSize to 2 the hostname can be empty on

UNIX-like machines.

diff --git a/libfreerdp/core/settings.c b/libfreerdp/core/settings.c
index 4d249eb..d76fb0c 100644 (file)
--- a/libfreerdp/core/settings.c
+++ b/libfreerdp/core/settings.c
@@ -255,8 +255,7 @@ BOOL settings_get_computer_name(rdpSettings* settings)
        DWORD nSize = 0;
        CHAR* computerName;
 
-       if (GetComputerNameExA(ComputerNameNetBIOS, NULL, &nSize) || (GetLastError() != ERROR_MORE_DATA) ||
-           (nSize < 2))
+       if (GetComputerNameExA(ComputerNameNetBIOS, NULL, &nSize) || GetLastError() != ERROR_MORE_DATA)
                return FALSE;
 
        computerName = calloc(nSize, sizeof(CHAR));

diff --git a/winpr/libwinpr/sspi/NTLM/ntlm.c b/winpr/libwinpr/sspi/NTLM/ntlm.c
index e6ce48a..593558b 100644 (file)
--- a/winpr/libwinpr/sspi/NTLM/ntlm.c
+++ b/winpr/libwinpr/sspi/NTLM/ntlm.c
@@ -52,8 +52,7 @@ static int ntlm_SetContextWorkstation(NTLM_CONTEXT* context, char* Workstation)
 
        if (!Workstation)
        {
-               if (GetComputerNameExA(ComputerNameNetBIOS, NULL, &nSize) || (GetLastError() != ERROR_MORE_DATA) ||
-                   (nSize < 2))
+               if (GetComputerNameExA(ComputerNameNetBIOS, NULL, &nSize) || GetLastError() != ERROR_MORE_DATA)
                        return -1;
 
                computerName = calloc(nSize, sizeof(CHAR));
@@ -133,8 +132,7 @@ static int ntlm_SetContextTargetName(NTLM_CONTEXT* context, char* TargetName)
 
        if (!name)
        {
-               if (GetComputerNameExA(ComputerNameNetBIOS, NULL, &nSize) || (GetLastError() != ERROR_MORE_DATA) ||
-                   (nSize < 2))
+               if (GetComputerNameExA(ComputerNameNetBIOS, NULL, &nSize) || GetLastError() != ERROR_MORE_DATA)
                        return -1;
 
                computerName = calloc(nSize, sizeof(CHAR));

diff --git a/winpr/libwinpr/sspi/NTLM/ntlm_av_pairs.c b/winpr/libwinpr/sspi/NTLM/ntlm_av_pairs.c
index 68ecc1f..d593a0e 100644 (file)
--- a/winpr/libwinpr/sspi/NTLM/ntlm_av_pairs.c
+++ b/winpr/libwinpr/sspi/NTLM/ntlm_av_pairs.c
@@ -180,8 +180,7 @@ int ntlm_get_target_computer_name(PUNICODE_STRING pName, COMPUTER_NAME_FORMAT ty
        DWORD nSize = 0;
        CHAR* computerName;
 
-       if (GetComputerNameExA(ComputerNameNetBIOS, NULL, &nSize) || (GetLastError() != ERROR_MORE_DATA) ||
-           (nSize < 2))
+       if (GetComputerNameExA(ComputerNameNetBIOS, NULL, &nSize) || GetLastError() != ERROR_MORE_DATA)
                return -1;
 
        computerName = calloc(nSize, sizeof(CHAR));