Run a few more binutils tests non-native
authorAlan Modra <amodra@gmail.com>
Tue, 29 May 2018 01:23:18 +0000 (10:53 +0930)
committerAlan Modra <amodra@gmail.com>
Thu, 31 May 2018 02:30:11 +0000 (12:00 +0930)
Setting CC_FOR_TARGET from the environment CC was just plain wrong,
and no doubt the reason these tests were only run natively.

* testsuite/binutils-all/compress.exp (test_gnu_debuglink): Don't
set CC_FOR_TARGET.  Run test non-native.
* testsuite/binutils-all/objdump.exp (test_build_id_debuglink):
Likewise.
(test_follow_debuglink): Run test non-native.

binutils/ChangeLog
binutils/testsuite/binutils-all/compress.exp
binutils/testsuite/binutils-all/objdump.exp

index 8e1172a..c603c78 100644 (file)
@@ -1,3 +1,11 @@
+2018-05-31  Alan Modra  <amodra@gmail.com>
+
+       * testsuite/binutils-all/compress.exp (test_gnu_debuglink): Don't
+       set CC_FOR_TARGET.  Run test non-native.
+       * testsuite/binutils-all/objdump.exp (test_build_id_debuglink):
+       Likewise.
+       (test_follow_debuglink): Run test non-native.
+
 2018-05-30  Ant Bikeneev  <ant.bikineev@gmail.com>
 
        PR 23107
index edbe9dd..948d20a 100644 (file)
@@ -677,19 +677,11 @@ proc test_gnu_debuglink {} {
     global srcdir
     global subdir
     global env
-    global CC_FOR_TARGET
     global STRIP
     global OBJCOPY
     global OBJDUMP
 
     set test "gnu-debuglink"
-    if {![info exists CC_FOR_TARGET]} {
-       set CC_FOR_TARGET $env(CC)
-    }
-    if { $CC_FOR_TARGET == "" } {
-       unsupported $test
-       return
-    }
 
     if { [target_compile $srcdir/$subdir/testprog.c tmpdir/testprog exectuable debug] != "" } {
        unsupported "$test (build)"
@@ -762,6 +754,6 @@ proc test_gnu_debuglink {} {
     }
 }
 
-if {[isnative] && [is_elf_format]} then {
+if {[is_elf_format]} then {
     test_gnu_debuglink
 }
index d9d0713..effc3dd 100644 (file)
@@ -347,20 +347,12 @@ proc test_build_id_debuglink {} {
     global srcdir
     global subdir
     global env
-    global CC_FOR_TARGET
     global STRIP
     global OBJCOPY
     global OBJDUMP
     global CFLAGS_FOR_TARGET
     
     set test "build-id-debuglink"
-    if {![info exists CC_FOR_TARGET]} {
-       set CC_FOR_TARGET $env(CC)
-    }
-    if { $CC_FOR_TARGET == "" } {
-       unsupported $test
-       return
-    }
 
     # Use a fixed build-id.
     if { [info exists CFLAGS_FOR_TARGET] } {
@@ -427,7 +419,7 @@ proc test_build_id_debuglink {} {
     }
 }
 
-if {[isnative] && [is_elf_format]} then {
+if {[is_elf_format]} then {
     test_build_id_debuglink
 }
 
@@ -509,7 +501,7 @@ proc test_follow_debuglink {} {
     set got [remote_exec host "rm tmpdir/linkdebug.debug"]
 }
 
-if {[isnative] && [is_elf_format]} then {
+if {[is_elf_format]} then {
     test_follow_debuglink
 }