drm/powerplay: Ratelimit PP_ASSERT warnings
authorKent Russell <kent.russell@amd.com>
Wed, 12 Feb 2020 14:33:13 +0000 (09:33 -0500)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 12 Feb 2020 21:04:31 +0000 (16:04 -0500)
In certain situations the message could be reported dozens-to-hundreds of
times, based on how often the function is called.
E.g. If MCLK DPM, any calls to get/set MCLK will result in a failure
message, potentially flooding dmesg. Ratelimit the warnings to avoid
this flood.

Signed-off-by: Kent Russell <kent.russell@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/powerplay/inc/pp_debug.h

index 822cd8b..cea6509 100644 (file)
@@ -37,7 +37,7 @@
 #define PP_ASSERT_WITH_CODE(cond, msg, code)   \
        do {                                    \
                if (!(cond)) {                  \
-                       pr_warn("%s\n", msg);   \
+                       pr_warn_ratelimited("%s\n", msg);       \
                        code;                   \
                }                               \
        } while (0)
@@ -45,7 +45,7 @@
 #define PP_ASSERT(cond, msg)   \
        do {                                    \
                if (!(cond)) {                  \
-                       pr_warn("%s\n", msg);   \
+                       pr_warn_ratelimited("%s\n", msg);       \
                }                               \
        } while (0)