projects
/
platform
/
kernel
/
linux-starfive.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
|
inline
| side by side (parent:
b81c14c
)
block: remove useless BUG_ON() in blk_mq_put_tag()
author
Damien Le Moal
<damien.lemoal@opensource.wdc.com>
Thu, 2 Jun 2022 07:51:59 +0000
(16:51 +0900)
committer
Jens Axboe
<axboe@kernel.dk>
Thu, 2 Jun 2022 08:05:56 +0000
(
02:05
-0600)
Since the if condition in blk_mq_put_tag() checks that the tag to put is
not a reserved one, the BUG_ON() check in the else branch checking if
the tag is indeed a reserved one is useless. Remove it.
Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Link:
https://lore.kernel.org/r/20220602075159.1273366-1-damien.lemoal@opensource.wdc.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-mq-tag.c
patch
|
blob
|
history
diff --git
a/block/blk-mq-tag.c
b/block/blk-mq-tag.c
index
68ac23d
..
2dcd738
100644
(file)
--- a/
block/blk-mq-tag.c
+++ b/
block/blk-mq-tag.c
@@
-228,7
+228,6
@@
void blk_mq_put_tag(struct blk_mq_tags *tags, struct blk_mq_ctx *ctx,
BUG_ON(real_tag >= tags->nr_tags);
sbitmap_queue_clear(&tags->bitmap_tags, real_tag, ctx->cpu);
} else {
BUG_ON(real_tag >= tags->nr_tags);
sbitmap_queue_clear(&tags->bitmap_tags, real_tag, ctx->cpu);
} else {
- BUG_ON(tag >= tags->nr_reserved_tags);
sbitmap_queue_clear(&tags->breserved_tags, tag, ctx->cpu);
}
}
sbitmap_queue_clear(&tags->breserved_tags, tag, ctx->cpu);
}
}