qtdemux: Check for invalid (empty) classification info entity strings

Otherwise the classification string can be empty and gst_tag_list_add() will
complain or have a \0 in the first four bytes, which is wrong too.

diff --git a/gst/qtdemux/qtdemux.c b/gst/qtdemux/qtdemux.c
index 63871a5a86464e9401733e8ad78a9c186411e656..64a9d445643b19bea8cc4641edee01e0bbd8e5ef 100644 (file)
--- a/gst/qtdemux/qtdemux.c
+++ b/gst/qtdemux/qtdemux.c
@@ -7584,6 +7584,12 @@ qtdemux_tag_add_classification (GstQTDemux * qtdemux, const char *tag,
 
   offset = 12;
   entity = (guint8 *) node->data + offset;
 
   offset = 12;
   entity = (guint8 *) node->data + offset;

+  if (entity[0] == 0 || entity[1] == 0 || entity[2] == 0 || entity[3] == 0) {
+    GST_DEBUG_OBJECT (qtdemux,
+        "classification info: %c%c%c%c invalid classification entity",
+        entity[0], entity[1], entity[2], entity[3]);
+    return;
+  }

 
   offset += 4;
   table = QT_UINT16 ((guint8 *) node->data + offset);
 
   offset += 4;
   table = QT_UINT16 ((guint8 *) node->data + offset);