drm: bridge: cdns-mhdp8546: Fix PM reference leak in

pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here.
Fix it by replacing it with pm_runtime_resume_and_get to keep usage
counter balanced.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Reviewed-by: Robert Foss <robert.foss@linaro.org>
Signed-off-by: Robert Foss <robert.foss@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20210531135622.3348252-1-yukuai3@huawei.com

diff --git a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c
index 82619db..5530fbf 100644 (file)
--- a/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c
+++ b/drivers/gpu/drm/bridge/cadence/cdns-mhdp8546-core.c
@@ -2478,9 +2478,9 @@ static int cdns_mhdp_probe(struct platform_device *pdev)
        clk_prepare_enable(clk);
 
        pm_runtime_enable(dev);
        clk_prepare_enable(clk);
 
        pm_runtime_enable(dev);

-       ret = pm_runtime_get_sync(dev);
+       ret = pm_runtime_resume_and_get(dev);

        if (ret < 0) {
        if (ret < 0) {

-               dev_err(dev, "pm_runtime_get_sync failed\n");
+               dev_err(dev, "pm_runtime_resume_and_get failed\n");

                pm_runtime_disable(dev);
                goto clk_disable;
        }
                pm_runtime_disable(dev);
                goto clk_disable;
        }