props.c uses 'fprintf(stderr, "ERROR: ...")' as its error messages,
however we have generic error() function.
Signed-off-by: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fd = open(object, O_RDONLY);
if (fd < 0) {
ret = -errno;
fd = open(object, O_RDONLY);
if (fd < 0) {
ret = -errno;
- fprintf(stderr, "ERROR: open %s failed. %s\n",
- object, strerror(-ret));
+ error("failed to open %s: %s", object, strerror(-ret));
goto out;
}
ret = ioctl(fd, BTRFS_IOC_SUBVOL_GETFLAGS, &flags);
if (ret < 0) {
ret = -errno;
goto out;
}
ret = ioctl(fd, BTRFS_IOC_SUBVOL_GETFLAGS, &flags);
if (ret < 0) {
ret = -errno;
- fprintf(stderr, "ERROR: failed to get flags for %s. %s\n",
- object, strerror(-ret));
+ error("failed to get flags for %s: %s", object,
+ strerror(-ret));
flags = flags & ~BTRFS_SUBVOL_RDONLY;
} else {
ret = -EINVAL;
flags = flags & ~BTRFS_SUBVOL_RDONLY;
} else {
ret = -EINVAL;
- fprintf(stderr, "ERROR: invalid value for property.\n");
+ error("invalid value for property: %s", value);
goto out;
}
ret = ioctl(fd, BTRFS_IOC_SUBVOL_SETFLAGS, &flags);
if (ret < 0) {
ret = -errno;
goto out;
}
ret = ioctl(fd, BTRFS_IOC_SUBVOL_SETFLAGS, &flags);
if (ret < 0) {
ret = -errno;
- fprintf(stderr, "ERROR: failed to set flags for %s. %s\n",
- object, strerror(-ret));
+ error("failed to set flags for %s: %s", object,
+ strerror(-ret));
fd = open_file_or_dir3(object, &dirstream, open_flags);
if (fd == -1) {
ret = -errno;
fd = open_file_or_dir3(object, &dirstream, open_flags);
if (fd == -1) {
ret = -errno;
- fprintf(stderr, "ERROR: open %s failed. %s\n",
- object, strerror(-ret));
+ error("failed to open %s: %s", object, strerror(-ret));
if (sret < 0) {
ret = -errno;
if (ret != -ENOATTR)
if (sret < 0) {
ret = -errno;
if (ret != -ENOATTR)
- fprintf(stderr,
- "ERROR: failed to %s compression for %s. %s\n",
- value ? "set" : "get", object, strerror(-ret));
+ error("failed to %s compression for %s: %s",
+ value ? "set" : "get", object, strerror(-ret));
sret = fgetxattr(fd, xattr_name, buf, len);
if (sret < 0) {
ret = -errno;
sret = fgetxattr(fd, xattr_name, buf, len);
if (sret < 0) {
ret = -errno;
- fprintf(stderr,
- "ERROR: failed to get compression for %s. %s\n",
- object, strerror(-ret));
+ error("failed to get compression for %s: %s",
+ object, strerror(-ret));
goto out;
}
fprintf(stdout, "compression=%.*s\n", (int)len, buf);
goto out;
}
fprintf(stdout, "compression=%.*s\n", (int)len, buf);