projects
/
platform
/
upstream
/
connman.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
|
inline
| side by side (parent:
ba18b4a
)
service: Must not return NULL with a synchronous GDBus method call
author
Patrik Flykt
<patrik.flykt@linux.intel.com>
Mon, 28 Jan 2013 15:44:43 +0000
(17:44 +0200)
committer
Patrik Flykt
<patrik.flykt@linux.intel.com>
Wed, 30 Jan 2013 08:28:46 +0000
(10:28 +0200)
If NULL is returned, GDBus will call the registered function repeatedly.
src/service.c
patch
|
blob
|
history
diff --git
a/src/service.c
b/src/service.c
index
1e7cec7
..
a1d4a2f
100644
(file)
--- a/
src/service.c
+++ b/
src/service.c
@@
-3765,8
+3765,6
@@
static DBusMessage *disconnect_service(DBusConnection *conn,
if (err < 0) {
if (err != -EINPROGRESS)
return __connman_error_failed(msg, -err);
if (err < 0) {
if (err != -EINPROGRESS)
return __connman_error_failed(msg, -err);
-
- return NULL;
}
return g_dbus_create_reply(msg, DBUS_TYPE_INVALID);
}
return g_dbus_create_reply(msg, DBUS_TYPE_INVALID);