GMemoryOutputStream: Don't return -1 as a gboolean in precondition
authorColin Walters <walters@verbum.org>
Tue, 8 Oct 2013 16:17:16 +0000 (12:17 -0400)
committerColin Walters <walters@verbum.org>
Tue, 8 Oct 2013 16:19:11 +0000 (12:19 -0400)
Since it could confuse callers (admittedly who are already violating
a precondition).

Just spotted while adapting some bits of this code for a ssh library.

gio/gmemoryoutputstream.c

index d37b46e..82edceb 100644 (file)
@@ -678,7 +678,7 @@ g_memory_output_stream_close_finish (GOutputStream  *stream,
                                      GAsyncResult   *result,
                                      GError        **error)
 {
                                      GAsyncResult   *result,
                                      GError        **error)
 {
-  g_return_val_if_fail (g_task_is_valid (result, stream), -1);
+  g_return_val_if_fail (g_task_is_valid (result, stream), FALSE);
 
   return g_task_propagate_boolean (G_TASK (result), error);
 }
 
   return g_task_propagate_boolean (G_TASK (result), error);
 }