proc: set attributes of pde using accessor functions
authorRui Xiang <rui.xiang@huawei.com>
Thu, 23 Jan 2014 23:55:41 +0000 (15:55 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Fri, 24 Jan 2014 00:37:01 +0000 (16:37 -0800)
Use existing accessors proc_set_user() and proc_set_size() to set
attributes.  Just a cleanup.

Signed-off-by: Rui Xiang <rui.xiang@huawei.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/proc/generic.c
fs/proc/proc_devtree.c

index cca93b6..b7f268e 100644 (file)
@@ -49,8 +49,7 @@ static int proc_notify_change(struct dentry *dentry, struct iattr *iattr)
        setattr_copy(inode, iattr);
        mark_inode_dirty(inode);
 
        setattr_copy(inode, iattr);
        mark_inode_dirty(inode);
 
-       de->uid = inode->i_uid;
-       de->gid = inode->i_gid;
+       proc_set_user(de, inode->i_uid, inode->i_gid);
        de->mode = inode->i_mode;
        return 0;
 }
        de->mode = inode->i_mode;
        return 0;
 }
index 70779b2..c824187 100644 (file)
@@ -74,9 +74,9 @@ __proc_device_tree_add_prop(struct proc_dir_entry *de, struct property *pp,
                return NULL;
 
        if (!strncmp(name, "security-", 9))
                return NULL;
 
        if (!strncmp(name, "security-", 9))
-               ent->size = 0; /* don't leak number of password chars */
+               proc_set_size(ent, 0); /* don't leak number of password chars */
        else
        else
-               ent->size = pp->length;
+               proc_set_size(ent, pp->length);
 
        return ent;
 }
 
        return ent;
 }