projects
/
platform
/
kernel
/
linux-starfive.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
|
inline
| side by side (parent:
51c8be0
)
leds: pwm: Fix error code in led_pwm_create_fwnode()
author
Dan Carpenter
<dan.carpenter@linaro.org>
Tue, 11 Jul 2023 06:13:34 +0000
(09:13 +0300)
committer
Lee Jones
<lee@kernel.org>
Fri, 28 Jul 2023 08:26:24 +0000
(09:26 +0100)
Negative -EINVAL was intended, not positive EINVAL. Fix it.
Fixes:
95138e01275e
("leds: pwm: Make error handling more robust")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Link:
https://lore.kernel.org/r/a33b981a-b2c4-4dc2-b00a-626a090d2f11@moroto.mountain
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/leds/leds-pwm.c
patch
|
blob
|
history
diff --git
a/drivers/leds/leds-pwm.c
b/drivers/leds/leds-pwm.c
index
29194cc
..
87c1992
100644
(file)
--- a/
drivers/leds/leds-pwm.c
+++ b/
drivers/leds/leds-pwm.c
@@
-146,7
+146,7
@@
static int led_pwm_create_fwnode(struct device *dev, struct led_pwm_priv *priv)
led.name = to_of_node(fwnode)->name;
if (!led.name) {
led.name = to_of_node(fwnode)->name;
if (!led.name) {
- ret = EINVAL;
+ ret =
-
EINVAL;
goto err_child_out;
}
goto err_child_out;
}