ALSA: emux: Adjust one function call together with a variable assignment
authorMarkus Elfring <elfring@users.sourceforge.net>
Wed, 9 Aug 2017 06:40:14 +0000 (08:40 +0200)
committerTakashi Iwai <tiwai@suse.de>
Thu, 10 Aug 2017 15:55:09 +0000 (17:55 +0200)
The script "checkpatch.pl" pointed information out like the following.

ERROR: do not use assignment in if condition

Thus fix the affected source code place.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/synth/emux/emux_seq.c

index 55579f6..53820f7 100644 (file)
@@ -144,7 +144,8 @@ snd_emux_create_port(struct snd_emux *emu, char *name,
        int i, type, cap;
 
        /* Allocate structures for this channel */
        int i, type, cap;
 
        /* Allocate structures for this channel */
-       if ((p = kzalloc(sizeof(*p), GFP_KERNEL)) == NULL) {
+       p = kzalloc(sizeof(*p), GFP_KERNEL);
+       if (!p) {
                snd_printk(KERN_ERR "no memory\n");
                return NULL;
        }
                snd_printk(KERN_ERR "no memory\n");
                return NULL;
        }