summary |
shortlog |
log |
commit | commitdiff |
tree
raw |
patch |
inline | side by side (from parent 1:
84860c7)
In net/ieee802154/nl-phy.c::ieee802154_nl_fill_phy() I see two small
issues.
1) If the allocation of 'buf' fails we may just as well return -EMSGSIZE
directly rather than jumping to 'out:' and do a pointless kfree(0).
2) We do not free 'buf' unless we jump to one of the error labels and this
leaks memory.
This patch should address both.
Signed-off-by: Jesper Juhl <jj@chaosbits.net>
Acked-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>
Signed-off-by: David S. Miller <davem@conan.davemloft.net>
pr_debug("%s\n", __func__);
if (!buf)
pr_debug("%s\n", __func__);
if (!buf)
hdr = genlmsg_put(msg, 0, seq, &nl802154_family, flags,
IEEE802154_LIST_PHY);
hdr = genlmsg_put(msg, 0, seq, &nl802154_family, flags,
IEEE802154_LIST_PHY);
pages * sizeof(uint32_t), buf);
mutex_unlock(&phy->pib_lock);
pages * sizeof(uint32_t), buf);
mutex_unlock(&phy->pib_lock);
return genlmsg_end(msg, hdr);
nla_put_failure:
return genlmsg_end(msg, hdr);
nla_put_failure: