tui_set_layout sets regs_populate using:
regs_populate = (new_layout == SRC_DATA_COMMAND
|| new_layout == DISASSEM_DATA_COMMAND);
Then later it checks this variable:
if (!regs_populate
&& (new_layout == SRC_DATA_COMMAND
|| new_layout == DISASSEM_DATA_COMMAND))
However, this is equivalent to "!regs_populate && regs_populate",
which can never be true. So, remove the dead code and the variable.
gdb/ChangeLog
2019-07-17 Tom Tromey <tom@tromey.com>
* tui/tui-layout.c (tui_set_layout): Remove regs_populate
variable.
2019-07-17 Tom Tromey <tom@tromey.com>
2019-07-17 Tom Tromey <tom@tromey.com>
+ * tui/tui-layout.c (tui_set_layout): Remove regs_populate
+ variable.
+
+2019-07-17 Tom Tromey <tom@tromey.com>
+
* tui/tui.c (tui_rl_other_window): Update.
* tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
superclass method first. Always iterate over regs_content.
* tui/tui.c (tui_rl_other_window): Update.
* tui/tui-wingeneral.c (tui_data_window::refresh_window): Call
superclass method first. Always iterate over regs_content.
if (layout_type != UNDEFINED_LAYOUT)
{
if (layout_type != UNDEFINED_LAYOUT)
{
- enum tui_layout_type cur_layout = tui_current_layout (),
- new_layout = UNDEFINED_LAYOUT;
- int regs_populate = FALSE;
+ enum tui_layout_type cur_layout = tui_current_layout ();
struct gdbarch *gdbarch;
CORE_ADDR addr;
struct tui_win_info *win_with_focus = tui_win_with_focus ();
struct gdbarch *gdbarch;
CORE_ADDR addr;
struct tui_win_info *win_with_focus = tui_win_with_focus ();
extract_display_start_addr (&gdbarch, &addr);
extract_display_start_addr (&gdbarch, &addr);
- new_layout = layout_type;
+ enum tui_layout_type new_layout = layout_type;
- regs_populate = (new_layout == SRC_DATA_COMMAND
- || new_layout == DISASSEM_DATA_COMMAND);
if (new_layout != cur_layout)
{
show_layout (new_layout);
if (new_layout != cur_layout)
{
show_layout (new_layout);
/*
* Now update the window content.
*/
/*
* Now update the window content.
*/
- if (!regs_populate
- && (new_layout == SRC_DATA_COMMAND
- || new_layout == DISASSEM_DATA_COMMAND))
- TUI_DATA_WIN->display_all_data ();
-
tui_update_source_windows_with_addr (gdbarch, addr);
tui_update_source_windows_with_addr (gdbarch, addr);
+ if (new_layout == SRC_DATA_COMMAND
+ || new_layout == DISASSEM_DATA_COMMAND)
tui_show_registers (TUI_DATA_WIN->current_group);
}
}
tui_show_registers (TUI_DATA_WIN->current_group);
}
}