selftests/bpf: Test_progs indicate to shell on non-actions
authorJesper Dangaard Brouer <brouer@redhat.com>
Wed, 1 Jul 2020 21:44:07 +0000 (23:44 +0200)
committerAlexei Starovoitov <ast@kernel.org>
Wed, 1 Jul 2020 22:22:13 +0000 (15:22 -0700)
When a user selects a non-existing test the summary is printed with
indication 0 for all info types, and shell "success" (EXIT_SUCCESS) is
indicated. This can be understood by a human end-user, but for shell
scripting is it useful to indicate a shell failure (EXIT_FAILURE).

Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Acked-by: Andrii Nakryiko <andriin@fb.com>
Link: https://lore.kernel.org/bpf/159363984736.930467.17956007131403952343.stgit@firesoul
tools/testing/selftests/bpf/test_progs.c

index 54fa5fa688ce92d2096e028ac534ab4b099ddec8..da70a4f72f547a0ded1513d65e58191571e5522f 100644 (file)
@@ -687,5 +687,8 @@ int main(int argc, char **argv)
        free_str_set(&env.subtest_selector.whitelist);
        free(env.subtest_selector.num_set);
 
        free_str_set(&env.subtest_selector.whitelist);
        free(env.subtest_selector.num_set);
 
+       if (env.succ_cnt + env.fail_cnt + env.skip_cnt == 0)
+               return EXIT_FAILURE;
+
        return env.fail_cnt ? EXIT_FAILURE : EXIT_SUCCESS;
 }
        return env.fail_cnt ? EXIT_FAILURE : EXIT_SUCCESS;
 }