Input: ps2-gpio - actually abort probe when connected to sleeping GPIOs
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Mon, 23 Oct 2017 23:40:42 +0000 (16:40 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Tue, 24 Oct 2017 17:10:11 +0000 (10:10 -0700)
We've been missing a goto to the unwind path...

Acked-by: Danilo Krummrich <danilokrummrich@dk-develop.de>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/serio/ps2-gpio.c

index b50e381..c62cceb 100644 (file)
@@ -366,6 +366,7 @@ static int ps2_gpio_probe(struct platform_device *pdev)
            gpiod_cansleep(drvdata->gpio_clk)) {
                dev_err(dev, "GPIO data or clk are connected via slow bus\n");
                error = -EINVAL;
            gpiod_cansleep(drvdata->gpio_clk)) {
                dev_err(dev, "GPIO data or clk are connected via slow bus\n");
                error = -EINVAL;
+               goto err_free_serio;
        }
 
        drvdata->irq = platform_get_irq(pdev, 0);
        }
 
        drvdata->irq = platform_get_irq(pdev, 0);