pci: Add checks for valid cmdline arguments

Currently pci command ignores invalid cmdline arguments and do something.
Add checks that all passed arguments were processed.

Signed-off-by: Pali Rohár <pali@kernel.org>
Reviewed-by: Stefan Roese <sr@denx.de>

diff --git a/cmd/pci.c b/cmd/pci.c
index 96e6fbd..ca8f6f5 100644 (file)
--- a/cmd/pci.c
+++ b/cmd/pci.c
@@ -523,7 +523,12 @@ static int do_pci(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[])
                        }
                        if (argc > 2 || (argc > 1 && cmd != 'r' && argv[1][0] != 's')) {
                                busnum = hextoul(argv[argc - 1], NULL);
                        }
                        if (argc > 2 || (argc > 1 && cmd != 'r' && argv[1][0] != 's')) {
                                busnum = hextoul(argv[argc - 1], NULL);

+                               argc--;

                        }
                        }

+                       if (cmd == 'r' && argc > 2)
+                               goto usage;
+                       else if (cmd != 'r' && (argc > 2 || (argc == 2 && argv[1][0] != 's')))
+                               goto usage;

                }
                ret = uclass_get_device_by_seq(UCLASS_PCI, busnum, &bus);
                if (ret) {
                }
                ret = uclass_get_device_by_seq(UCLASS_PCI, busnum, &bus);
                if (ret) {