matroskamux: fix PAR fraction sanity check

It was checking par_num twice, and never par_denum.

Coverity 1139634

diff --git a/gst/matroska/matroska-mux.c b/gst/matroska/matroska-mux.c
index 7347509002c5ed8a8dfef75a145b60e4ee0938fe..e1472d9cbe596930ef810a82344ff9c52f467b3b 100644 (file)
--- a/gst/matroska/matroska-mux.c
+++ b/gst/matroska/matroska-mux.c
@@ -1416,7 +1416,7 @@ theora_streamheader_to_codecdata (const GValue * streamheader,
     hdr += 4 + 4;
     par_num = GST_READ_UINT32_BE (hdr) >> 8;
     par_denom = GST_READ_UINT32_BE (hdr + 3) >> 8;
     hdr += 4 + 4;
     par_num = GST_READ_UINT32_BE (hdr) >> 8;
     par_denom = GST_READ_UINT32_BE (hdr + 3) >> 8;

-    if (par_num > 0 && par_num > 0) {
+    if (par_num > 0 && par_denom > 0) {

       if (par_num > par_denom) {
         videocontext->display_width =
             videocontext->pixel_width * par_num / par_denom;
       if (par_num > par_denom) {
         videocontext->display_width =
             videocontext->pixel_width * par_num / par_denom;