mpegtsmux: Fix memory leak when using prepare_func

prepare_func will allocate a new buffer to replace the original
one. Instead of using gst_buffer_replace (which causes an extra
refcount increment on the new buffer), we just unref the original
buffer.

https://bugzilla.gnome.org/show_bug.cgi?id=699786

diff --git a/gst/mpegtsmux/mpegtsmux.c b/gst/mpegtsmux/mpegtsmux.c
index 78e7cbd5688bbce1cf575966489779138fc02550..ed5f98823e049c41d59c09a198ca70788393ae87 100644 (file)
--- a/gst/mpegtsmux/mpegtsmux.c
+++ b/gst/mpegtsmux/mpegtsmux.c
@@ -1018,9 +1018,9 @@ mpegtsmux_clip_inc_running_time (GstCollectPads * pads,
   if (pad_data->prepare_func) {
     MpegTsMux *mux = (MpegTsMux *) user_data;
 
   if (pad_data->prepare_func) {
     MpegTsMux *mux = (MpegTsMux *) user_data;
 

-    buf = pad_data->prepare_func (buf, pad_data, mux);
-    if (buf)
-      gst_buffer_replace (outbuf, buf);
+    *outbuf = pad_data->prepare_func (buf, pad_data, mux);
+    g_assert (*outbuf);
+    gst_buffer_unref (buf);

   }
 
   return GST_FLOW_OK;
   }
 
   return GST_FLOW_OK;