CVS patchset: 5178
CVS date: 2001/11/12 22:54:39
continue;
}
while ((t - ps->probs) < ps->numProblems) {
continue;
}
while ((t - ps->probs) < ps->numProblems) {
- /*@-nullpass@*/ /* LCL: looks good to me */
+ /*@-nullpass@*/ /* LCL: looks good to me <shrug> */
if (f->type == t->type && t->key == f->key &&
XSTRCMP(f->str1, t->str1))
/*@innerbreak@*/ break;
if (f->type == t->type && t->key == f->key &&
XSTRCMP(f->str1, t->str1))
/*@innerbreak@*/ break;
while ((h = rpmdbNextIterator(qva->qva_mi)) != NULL) {
int rc;
while ((h = rpmdbNextIterator(qva->qva_mi)) != NULL) {
int rc;
if ((rc = qva->qva_showPackage(qva, ts, h)) != 0)
ec = rc;
if ((rc = qva->qva_showPackage(qva, ts, h)) != 0)
ec = rc;
}
qva->qva_mi = rpmdbFreeIterator(qva->qva_mi);
return ec;
}
qva->qva_mi = rpmdbFreeIterator(qva->qva_mi);
return ec;
int res = 0;
Header h;
int rc;
int res = 0;
Header h;
int rc;
if (qva->qva_showPackage == NULL)
return 1;
if (qva->qva_showPackage == NULL)
return 1;
- /*@-mustmod@*/ /* LCL: something fishy here, was segfault */
+ /*@=mustmod@*/ /* LCL: something fishy here, was segfault */
rpmrc = rpmReadPackageFile(ts, fd, fileURL, &h);
/*@=mustmod@*/
ts->verify_legacy = 0;
rpmrc = rpmReadPackageFile(ts, fd, fileURL, &h);
/*@=mustmod@*/
ts->verify_legacy = 0;
int anyarch = 1;
int force = 1;
int anyarch = 1;
int force = 1;
+ /*@-mods@*/ /* FIX: make spec abstract */
rc = parseSpecVec(&spec, arg, "/", buildRoot, recursing, passPhrase,
cookie, anyarch, force);
/*@=mods@*/
rc = parseSpecVec(&spec, arg, "/", buildRoot, recursing, passPhrase,
cookie, anyarch, force);
/*@=mods@*/
- for (pkg = spec->packages; pkg != NULL; pkg = pkg->next) {
- /*@-noeffectuncon@*/ /* FIX: check rc */
- (void) qva->qva_showPackage(qva, ts, pkg->header);
- /*@=noeffectuncon@*/
- }
+ for (pkg = spec->packages; pkg != NULL; pkg = pkg->next)
+ xx = qva->qva_showPackage(qva, ts, pkg->header);
spec = freeSpecVec(spec);
} break;
spec = freeSpecVec(spec);
} break;
if (*s == '\0') {
char fnbuf[PATH_MAX];
if (*s == '\0') {
char fnbuf[PATH_MAX];
- /*@-unrecog -moduncon @*/
fn = realpath(arg, fnbuf);
fn = realpath(arg, fnbuf);
- /*@=unrecog =moduncon @*/;
if (fn)
fn = xstrdup(fn);
else
if (fn)
fn = xstrdup(fn);
else
/*@unchecked@*/
static int _fi_debug = 0;
/*@unchecked@*/
static int _fi_debug = 0;
+/**
+ * Enable noisy range comparison debugging message?
+ */
+/*@unchecked@*/
+static int _noisy_range_comparison_debug_message = 0;
+
TFI_t XrpmfiUnlink(TFI_t fi, const char * msg, const char * fn, unsigned ln)
{
if (fi == NULL) return NULL;
TFI_t XrpmfiUnlink(TFI_t fi, const char * msg, const char * fn, unsigned ln)
{
if (fi == NULL) return NULL;
+ if (_noisy_range_comparison_debug_message)
rpmMessage(RPMMESS_DEBUG, _(" %s A %s\tB %s\n"),
(result ? _("YES") : _("NO ")), aDepend, bDepend);
aDepend = _free(aDepend);
rpmMessage(RPMMESS_DEBUG, _(" %s A %s\tB %s\n"),
(result ? _("YES") : _("NO ")), aDepend, bDepend);
aDepend = _free(aDepend);
/** \ingroup rpmtrans
* Process all packages in transaction set.
/** \ingroup rpmtrans
* Process all packages in transaction set.
+ *
+ * @warning The value returned in *newProbs is now refcounted, and should
+ * be free'd using rpmProblemSetFree().
+ *
* @param ts transaction set
* @param notify progress callback
* @param notifyData progress callback private data
* @param ts transaction set
* @param notify progress callback
* @param notifyData progress callback private data
/*@switchbreak@*/ break;
case TR_REMOVED:
default:
/*@switchbreak@*/ break;
case TR_REMOVED:
default:
- /*@-mods@*/ /* FIX: double indirection. */
/*@switchbreak@*/ break;
}
e++;
/*@switchbreak@*/ break;
}
e++;
fi->fmodes[fileNum],
fi->fmd5s[fileNum],
fi->flinks[fileNum])) {
fi->fmodes[fileNum],
fi->fmd5s[fileNum],
fi->flinks[fileNum])) {
- /*@-compdef@*/ /* FIX: *fi->replaced undefined */
if (reportConflicts) {
const char * altNEVR = hGetNEVR(h, NULL);
rpmProblemSetAppend(ts->probs, RPMPROB_FILE_CONFLICT,
if (reportConflicts) {
const char * altNEVR = hGetNEVR(h, NULL);
rpmProblemSetAppend(ts->probs, RPMPROB_FILE_CONFLICT,
0);
altNEVR = _free(altNEVR);
}
0);
altNEVR = _free(altNEVR);
}
if (!(otherFlags[otherFileNum] | fi->fflags[fileNum])
& RPMFILE_CONFIG) {
if (!(otherFlags[otherFileNum] | fi->fflags[fileNum])
& RPMFILE_CONFIG) {
+ /*@-assignexpose@*/ /* FIX: p->replaced, not fi */
if (!shared->isRemoved)
fi->replaced[numReplaced++] = *shared;
/*@=assignexpose@*/
if (!shared->isRemoved)
fi->replaced[numReplaced++] = *shared;
/*@=assignexpose@*/
}
/* Mark added overlapped non-identical files as a conflict. */
}
/* Mark added overlapped non-identical files as a conflict. */
- /*@-branchstate@*/ /* FIX: p->key ??? */
if ((ts->ignoreSet & RPMPROB_FILTER_REPLACENEWFILES)
&& filecmp(recs[otherPkgNum]->fmodes[otherFileNum],
recs[otherPkgNum]->fmd5s[otherFileNum],
if ((ts->ignoreSet & RPMPROB_FILTER_REPLACENEWFILES)
&& filecmp(recs[otherPkgNum]->fmodes[otherFileNum],
recs[otherPkgNum]->fmd5s[otherFileNum],
/* Try to get the disk accounting correct even if a conflict. */
fixupSize = recs[otherPkgNum]->fsizes[otherFileNum];
/* Try to get the disk accounting correct even if a conflict. */
fixupSize = recs[otherPkgNum]->fsizes[otherFileNum];
rc = headerMatchesDepFlags(h, req);
req = dsFree(req);
rc = headerMatchesDepFlags(h, req);
req = dsFree(req);
- /*@-branchstate@*/ /* FIX: p->key ??? */
if (rc == 0) {
const char * altNEVR = hGetNEVR(h, NULL);
rpmProblemSetAppend(ts->probs, RPMPROB_OLDPACKAGE,
if (rc == 0) {
const char * altNEVR = hGetNEVR(h, NULL);
rpmProblemSetAppend(ts->probs, RPMPROB_OLDPACKAGE,
ts->notify = notify;
ts->notifyData = notifyData;
ts->notify = notify;
ts->notifyData = notifyData;
- /*@-assignexpose@*/
- ts->probs = *newProbs = rpmProblemSetCreate();
+ ts->probs = rpmProblemSetFree(ts->probs);
+ ts->probs = rpmProblemSetCreate();
*newProbs = rpmpsLink(ts->probs, "RunTransactions");
*newProbs = rpmpsLink(ts->probs, "RunTransactions");
ts->ignoreSet = ignoreSet;
ts->currDir = _free(ts->currDir);
ts->currDir = currentDirectory();
ts->ignoreSet = ignoreSet;
ts->currDir = _free(ts->currDir);
ts->currDir = currentDirectory();
ts->id = (int_32) time(NULL);
memset(psm, 0, sizeof(*psm));
ts->id = (int_32) time(NULL);
memset(psm, 0, sizeof(*psm));
psm->ts = rpmtsLink(ts, "tsRun");
psm->ts = rpmtsLink(ts, "tsRun");
/* Get available space on mounted file systems. */
if (!(ts->ignoreSet & RPMPROB_FILTER_DISKSPACE) &&
/* Get available space on mounted file systems. */
if (!(ts->ignoreSet & RPMPROB_FILTER_DISKSPACE) &&
while ((p = teNext(pi, TR_ADDED)) != NULL) {
rpmdbMatchIterator mi;
while ((p = teNext(pi, TR_ADDED)) != NULL) {
rpmdbMatchIterator mi;
- /*@-branchstate@*/ /* FIX: p->key ??? */
- if (!archOkay(p->arch) && !(ts->ignoreSet & RPMPROB_FILTER_IGNOREARCH))
- rpmProblemSetAppend(ts->probs, RPMPROB_BADARCH,
+ if (!(ts->ignoreSet & RPMPROB_FILTER_IGNOREARCH))
+ if (!archOkay(p->arch))
+ rpmProblemSetAppend(ts->probs, RPMPROB_BADARCH,
p->NEVR, p->key,
p->arch, NULL,
NULL, 0);
p->NEVR, p->key,
p->arch, NULL,
NULL, 0);
- if (!osOkay(p->os) && !(ts->ignoreSet & RPMPROB_FILTER_IGNOREOS))
- rpmProblemSetAppend(ts->probs, RPMPROB_BADOS,
+ if (!(ts->ignoreSet & RPMPROB_FILTER_IGNOREOS))
+ if (!osOkay(p->os))
+ rpmProblemSetAppend(ts->probs, RPMPROB_BADOS,
p->NEVR, p->key,
p->os, NULL,
NULL, 0);
p->NEVR, p->key,
p->os, NULL,
NULL, 0);
if (!(ts->ignoreSet & RPMPROB_FILTER_OLDPACKAGE)) {
Header h;
if (!(ts->ignoreSet & RPMPROB_FILTER_OLDPACKAGE)) {
Header h;
{
if (psm->ts != NULL)
psm->ts = rpmtsUnlink(psm->ts, "tsRun (problems)");
{
if (psm->ts != NULL)
psm->ts = rpmtsUnlink(psm->ts, "tsRun (problems)");
- /*@-nullstate@*/ /* FIX: ts->flList may be NULL */
}
/* ===============================================
}
/* ===============================================
rpmMessage(RPMMESS_DEBUG, "========== +++ %s\n", p->NEVR);
h = NULL;
{
rpmMessage(RPMMESS_DEBUG, "========== +++ %s\n", p->NEVR);
h = NULL;
{
- /*@-noeffectuncon @*/ /* FIX: ??? */
p->fd = ts->notify(fi->h, RPMCALLBACK_INST_OPEN_FILE, 0, 0,
p->key, ts->notifyData);
p->fd = ts->notify(fi->h, RPMCALLBACK_INST_OPEN_FILE, 0, 0,
p->key, ts->notifyData);
if (p->fd != NULL) {
rpmRC rpmrc;
if (p->fd != NULL) {
rpmRC rpmrc;
- /*@-mustmod@*/ /* LCL: segfault */
+ /*@=mustmod@*/ /* LCL: segfault */
rpmrc = rpmReadPackageFile(ts, p->fd,
"rpmRunTransactions", &h);
/*@=mustmod@*/
if (!(rpmrc == RPMRC_OK || rpmrc == RPMRC_BADSIZE)) {
rpmrc = rpmReadPackageFile(ts, p->fd,
"rpmRunTransactions", &h);
/*@=mustmod@*/
if (!(rpmrc == RPMRC_OK || rpmrc == RPMRC_BADSIZE)) {
- /*@-noeffectuncon @*/ /* FIX: check rc */
- (void) ts->notify(fi->h, RPMCALLBACK_INST_CLOSE_FILE,
+ p->fd = ts->notify(fi->h, RPMCALLBACK_INST_CLOSE_FILE,
0, 0,
p->key, ts->notifyData);
0, 0,
p->key, ts->notifyData);
psm->ts = rpmtsLink(ts, "rpmVerifyScript");
psm->ts = rpmtsLink(ts, "rpmVerifyScript");
- if (scriptFd != NULL) {
- /*@-type@*/ /* FIX: ??? */
ts->scriptFd = fdLink(scriptFd, "rpmVerifyScript");
ts->scriptFd = fdLink(scriptFd, "rpmVerifyScript");
- /*@=type@*/
- }
- /*@-type@*/
psm->fi = fiNew(ts, NULL, h, RPMTAG_BASENAMES, 1);
psm->fi = fiNew(ts, NULL, h, RPMTAG_BASENAMES, 1);
if (psm->fi != NULL) { /* XXX can't happen */
psm->stepName = "verify";
psm->scriptTag = RPMTAG_VERIFYSCRIPT;
psm->progTag = RPMTAG_VERIFYSCRIPTPROG;
rc = psmStage(psm, PSM_SCRIPT);
}
if (psm->fi != NULL) { /* XXX can't happen */
psm->stepName = "verify";
psm->scriptTag = RPMTAG_VERIFYSCRIPT;
psm->progTag = RPMTAG_VERIFYSCRIPTPROG;
rc = psmStage(psm, PSM_SCRIPT);
}
psm->fi = fiFree(psm->fi, 1);
psm->fi = fiFree(psm->fi, 1);
- if (scriptFd != NULL) {
- /*@-type@*/ /* FIX: ??? */
+ if (ts->scriptFd != NULL)
ts->scriptFd = fdFree(ts->scriptFd, "rpmVerifyScript");
ts->scriptFd = fdFree(ts->scriptFd, "rpmVerifyScript");
- /*@=type@*/
- ts->scriptFd = NULL;
- }
rpmtransClean(ts); /* XXX this is sure to cause heartburn */
rpmtransClean(ts); /* XXX this is sure to cause heartburn */
msgid ""
msgstr ""
"Project-Id-Version: PACKAGE VERSION\n"
msgid ""
msgstr ""
"Project-Id-Version: PACKAGE VERSION\n"
-"POT-Creation-Date: 2001-11-12 15:50-0500\n"
+"POT-Creation-Date: 2001-11-12 17:47-0500\n"
"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
"Language-Team: LANGUAGE <LL@li.org>\n"
"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
"Language-Team: LANGUAGE <LL@li.org>\n"
msgid "%9s: (%s, %s) added to Depends cache.\n"
msgstr ""
msgid "%9s: (%s, %s) added to Depends cache.\n"
msgstr ""
-#: lib/depends.c:795 lib/rpmds.c:656 lib/rpmds.c:814
+#: lib/depends.c:795 lib/rpmds.c:662 lib/rpmds.c:821
-#: lib/depends.c:795 lib/rpmds.c:656 lib/rpmds.c:814
+#: lib/depends.c:795 lib/rpmds.c:662 lib/rpmds.c:821
msgid "can't query %s: %s\n"
msgstr ""
msgid "can't query %s: %s\n"
msgstr ""
-#: lib/query.c:600 lib/query.c:638 lib/rpminstall.c:328 lib/rpminstall.c:470
+#: lib/query.c:599 lib/query.c:637 lib/rpminstall.c:328 lib/rpminstall.c:470
#: lib/rpminstall.c:840
#, c-format
msgid "open of %s failed: %s\n"
msgstr ""
#: lib/rpminstall.c:840
#, c-format
msgid "open of %s failed: %s\n"
msgstr ""
#, c-format
msgid "query of %s failed\n"
msgstr ""
#, c-format
msgid "query of %s failed\n"
msgstr ""
msgid "old format source packages cannot be queried\n"
msgstr ""
msgid "old format source packages cannot be queried\n"
msgstr ""
-#: lib/query.c:648 lib/rpminstall.c:483
+#: lib/query.c:647 lib/rpminstall.c:483
#, c-format
msgid "%s: read manifest failed: %s\n"
msgstr ""
#, c-format
msgid "%s: read manifest failed: %s\n"
msgstr ""
#, c-format
msgid "query of specfile %s failed, can't parse\n"
msgstr ""
#, c-format
msgid "query of specfile %s failed, can't parse\n"
msgstr ""
msgid "no packages\n"
msgstr ""
msgid "no packages\n"
msgstr ""
#, c-format
msgid "group %s does not contain any packages\n"
msgstr ""
#, c-format
msgid "group %s does not contain any packages\n"
msgstr ""
#, c-format
msgid "no package triggers %s\n"
msgstr ""
#, c-format
msgid "no package triggers %s\n"
msgstr ""
#, c-format
msgid "no package requires %s\n"
msgstr ""
#, c-format
msgid "no package requires %s\n"
msgstr ""
#, c-format
msgid "no package provides %s\n"
msgstr ""
#, c-format
msgid "no package provides %s\n"
msgstr ""
#, c-format
msgid "file %s: %s\n"
msgstr ""
#, c-format
msgid "file %s: %s\n"
msgstr ""
#, c-format
msgid "file %s is not owned by any package\n"
msgstr ""
#, c-format
msgid "file %s is not owned by any package\n"
msgstr ""
#, c-format
msgid "invalid package number: %s\n"
msgstr ""
#, c-format
msgid "invalid package number: %s\n"
msgstr ""
#, c-format
msgid "package record number: %u\n"
msgstr ""
#, c-format
msgid "package record number: %u\n"
msgstr ""
#, c-format
msgid "record %u could not be read\n"
msgstr ""
#, c-format
msgid "record %u could not be read\n"
msgstr ""
-#: lib/query.c:854 lib/rpminstall.c:628
+#: lib/query.c:848 lib/rpminstall.c:628
#, c-format
msgid "package %s is not installed\n"
msgstr ""
#, c-format
msgid "package %s is not installed\n"
msgstr ""
msgstr ""
#. XXX legacy epoch-less requires/conflicts compatibility
msgstr ""
#. XXX legacy epoch-less requires/conflicts compatibility
#, c-format
msgid ""
"the \"B\" dependency needs an epoch (assuming same as \"A\")\n"
"\tA %s\tB %s\n"
msgstr ""
#, c-format
msgid ""
"the \"B\" dependency needs an epoch (assuming same as \"A\")\n"
"\tA %s\tB %s\n"
msgstr ""
#, c-format
msgid " %s A %s\tB %s\n"
msgstr ""
#. @=branchstate@
#, c-format
msgid " %s A %s\tB %s\n"
msgstr ""
#. @=branchstate@
#, c-format
msgid "package %s has unsatisfied %s: %s\n"
msgstr ""
#, c-format
msgid "package %s has unsatisfied %s: %s\n"
msgstr ""
msgid "Signature: UNKNOWN (%d)\n"
msgstr ""
msgid "Signature: UNKNOWN (%d)\n"
msgstr ""
-#: lib/transaction.c:187
+#: lib/transaction.c:185
#, c-format
msgid "%s skipped due to missingok flag\n"
msgstr ""
#. @innercontinue@
#, c-format
msgid "%s skipped due to missingok flag\n"
msgstr ""
#. @innercontinue@
-#: lib/transaction.c:858
+#: lib/transaction.c:850
#, c-format
msgid "excluding directory %s\n"
msgstr ""
#, c-format
msgid "excluding directory %s\n"
msgstr ""
-#: lib/transaction.c:929
+#: lib/transaction.c:918
msgid "getting list of mounted filesystems\n"
msgstr ""
msgid "getting list of mounted filesystems\n"
msgstr ""
msgid "package lacks both group name and id lists (this should never happen)\n"
msgstr ""
msgid "package lacks both group name and id lists (this should never happen)\n"
msgstr ""
#, c-format
msgid "missing %s"
msgstr ""
#, c-format
msgid "missing %s"
msgstr ""
#, c-format
msgid "Unsatisifed dependencies for %s: "
msgstr ""
#, c-format
msgid "Unsatisifed dependencies for %s: "
msgstr ""
#, c-format
msgid "%s-%s-%s: immutable header region digest check failed\n"
msgstr ""
#, c-format
msgid "%s-%s-%s: immutable header region digest check failed\n"
msgstr ""