Drop some redundant initialization of local variables, a redundant
return statement and a redundant "else" from the ACPI thermal driver.
No functional impact.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org>
static int acpi_thermal_trips_update(struct acpi_thermal *tz, int flag)
{
static int acpi_thermal_trips_update(struct acpi_thermal *tz, int flag)
{
- acpi_status status = AE_OK;
unsigned long long tmp;
struct acpi_handle_list devices;
int valid = 0;
unsigned long long tmp;
struct acpi_handle_list devices;
int valid = 0;
tz->trips.critical.temperature,
tz->kelvin_offset);
return 0;
tz->trips.critical.temperature,
tz->kelvin_offset);
return 0;
- } else
- return -EINVAL;
}
static int thermal_get_trend(struct thermal_zone_device *thermal,
}
static int thermal_get_trend(struct thermal_zone_device *thermal,
static int acpi_thermal_get_info(struct acpi_thermal *tz)
{
static int acpi_thermal_get_info(struct acpi_thermal *tz)
{
static int acpi_thermal_add(struct acpi_device *device)
{
static int acpi_thermal_add(struct acpi_device *device)
{
- int result = 0;
- struct acpi_thermal *tz = NULL;
+ struct acpi_thermal *tz;
+ int result;
if (!device)
return -EINVAL;
if (!device)
return -EINVAL;
static int acpi_thermal_remove(struct acpi_device *device)
{
static int acpi_thermal_remove(struct acpi_device *device)
{
- struct acpi_thermal *tz = NULL;
+ struct acpi_thermal *tz;
if (!device || !acpi_driver_data(device))
return -EINVAL;
if (!device || !acpi_driver_data(device))
return -EINVAL;
static int __init acpi_thermal_init(void)
{
static int __init acpi_thermal_init(void)
{
dmi_check_system(thermal_dmi_table);
dmi_check_system(thermal_dmi_table);
{
acpi_bus_unregister_driver(&acpi_thermal_driver);
destroy_workqueue(acpi_thermal_pm_queue);
{
acpi_bus_unregister_driver(&acpi_thermal_driver);
destroy_workqueue(acpi_thermal_pm_queue);
}
module_init(acpi_thermal_init);
}
module_init(acpi_thermal_init);