In mi_interpreter_init, multiple MI consoles/channels are created and a quoting
character is given. In mi_console_raw_packet, we check if the value is not 0
to decide if we should quote the string, but we don't use the value. It is
hardcoded to ". We might never use another quoting character than an actual
quote, but I suggest we change it, for correctness. There is not visible
behavior change.
I changed the latest fputs_unfiltered changed to fputc_unfiltered just to stay
consistent.
gdb/ChangeLog:
2014-05-12 Simon Marchi <simon.marchi@ericsson.com>
* mi/mi-console.c (mi_console_raw_packet): Use the value from
mi_console->quote as the quoting character.
2014-05-12 Simon Marchi <simon.marchi@ericsson.com>
2014-05-12 Simon Marchi <simon.marchi@ericsson.com>
+ * mi/mi-console.c (mi_console_raw_packet): Use the value from
+ mi_console->quote as the quoting character.
+
+2014-05-12 Simon Marchi <simon.marchi@ericsson.com>
+
* MAINTAINERS (Write After Approval): Add "Simon Marchi".
2014-04-29 Tom Tromey <tromey@redhat.com>
* MAINTAINERS (Write After Approval): Add "Simon Marchi".
2014-04-29 Tom Tromey <tromey@redhat.com>
fputs_unfiltered (mi_console->prefix, mi_console->raw);
if (mi_console->quote)
{
fputs_unfiltered (mi_console->prefix, mi_console->raw);
if (mi_console->quote)
{
- fputs_unfiltered ("\"", mi_console->raw);
+ fputc_unfiltered (mi_console->quote, mi_console->raw);
fputstrn_unfiltered (buf, length_buf,
mi_console->quote, mi_console->raw);
fputstrn_unfiltered (buf, length_buf,
mi_console->quote, mi_console->raw);
- fputs_unfiltered ("\"\n", mi_console->raw);
+ fputc_unfiltered (mi_console->quote, mi_console->raw);
+ fputc_unfiltered ('\n', mi_console->raw);
}
else
{
fputstrn_unfiltered (buf, length_buf, 0, mi_console->raw);
}
else
{
fputstrn_unfiltered (buf, length_buf, 0, mi_console->raw);
- fputs_unfiltered ("\n", mi_console->raw);
+ fputc_unfiltered ('\n', mi_console->raw);
}
gdb_flush (mi_console->raw);
}
}
gdb_flush (mi_console->raw);
}