gas:

	* config/tc-arm.c (T_OPCODE_BRANCH, encode_arm_addr_mode_2)
	(encode_arm_addr_mode_3, encode_arm_cp_address, do_blx, do_t_blx)
	(do_t_branch, insns [b, bl]): Don't encode pipeline offset.
	(s_arm_elf_cons): Disallow use of (plt) suffix.
	(do_adrl): Adjust X_add_number unconditionally.
	(md_pcrel_from): Rename md_pcrel_from_section, add second segT
	argument.  Handle all adjustment for pipeline offset here.
	(md_apply_fix): No need to undo work of md_pcrel_from.  No
	need to extract pre-encoded pipeline adjustments from various
	branch instructions.  Generally, assume instructions are already
	all-bits-zero in the field being fixed up.  Remove all OBJ_ELF
	special cases.  Handle BFD_RELOC_ARM_PLT32 like
	BFD_RELOC_ARM_PCREL_BRANCH.
	(tc_gen_reloc): Remove OBJ_ELF special case.
	* config/tc-arm.c: Define MD_PCREL_FROM_SECTION.

gas/testsuite:
	* gas/arm/arm.exp: Don't special case ldconst, arm7t, or copro
	for *-wince-*.
	* gas/arm/wince_arm7t.d, gas/arm/wince_copro.d
	* gas/arm/wince_ldconst.d: Delete.

diff --git a/gas/ChangeLog b/gas/ChangeLog
index 806f5df..b990f43 100644 (file)
--- a/gas/ChangeLog
+++ b/gas/ChangeLog
@@ -1,3 +1,21 @@
+2005-06-30  Zack Weinberg  <zack@codesourcery.com>
+
+       * config/tc-arm.c (T_OPCODE_BRANCH, encode_arm_addr_mode_2)
+       (encode_arm_addr_mode_3, encode_arm_cp_address, do_blx, do_t_blx)
+       (do_t_branch, insns [b, bl]): Don't encode pipeline offset.
+       (s_arm_elf_cons): Disallow use of (plt) suffix.
+       (do_adrl): Adjust X_add_number unconditionally.
+       (md_pcrel_from): Rename md_pcrel_from_section, add second segT
+       argument.  Handle all adjustment for pipeline offset here.
+       (md_apply_fix): No need to undo work of md_pcrel_from.  No
+       need to extract pre-encoded pipeline adjustments from various
+       branch instructions.  Generally, assume instructions are already
+       all-bits-zero in the field being fixed up.  Remove all OBJ_ELF
+       special cases.  Handle BFD_RELOC_ARM_PLT32 like
+       BFD_RELOC_ARM_PCREL_BRANCH.
+       (tc_gen_reloc): Remove OBJ_ELF special case.
+       * config/tc-arm.c: Define MD_PCREL_FROM_SECTION.
+

 2005-06-30  Ben Elliston  <bje@gnu.org>
 
        * Makefile.am (check-DEJAGNU): Don't search for expect.
 2005-06-30  Ben Elliston  <bje@gnu.org>
 
        * Makefile.am (check-DEJAGNU): Don't search for expect.

diff --git a/gas/config/tc-arm.c b/gas/config/tc-arm.c
index 2288d99..c7cc1ff 100644 (file)
--- a/gas/config/tc-arm.c
+++ b/gas/config/tc-arm.c
@@ -485,7 +485,7 @@ struct asm_opcode
 #define T_OPCODE_PUSH  0xb400
 #define T_OPCODE_POP   0xbc00
 
 #define T_OPCODE_PUSH  0xb400
 #define T_OPCODE_POP   0xbc00
 

-#define T_OPCODE_BRANCH 0xe7fe
+#define T_OPCODE_BRANCH 0xe000

 
 #define THUMB_SIZE     2       /* Size of thumb instruction.  */
 #define THUMB_PP_PC_LR 0x0100
 
 #define THUMB_SIZE     2       /* Size of thumb instruction.  */
 #define THUMB_PP_PC_LR 0x0100


@@ -1970,8 +1970,15 @@ s_arm_elf_cons (int nbytes)
              reloc_howto_type *howto = bfd_reloc_type_lookup (stdoutput, reloc);
              int size = bfd_get_reloc_size (howto);
 
              reloc_howto_type *howto = bfd_reloc_type_lookup (stdoutput, reloc);
              int size = bfd_get_reloc_size (howto);
 

+             if (reloc == BFD_RELOC_ARM_PLT32)
+               {
+                 as_bad (_("(plt) is only valid on branch targets"));
+                 reloc = BFD_RELOC_UNUSED;
+                 size = 0;
+               }
+

              if (size > nbytes)
              if (size > nbytes)

-               as_bad ("%s relocations do not fit in %d bytes",
+               as_bad (_("%s relocations do not fit in %d bytes"),

                        howto->name, nbytes);
              else
                {
                        howto->name, nbytes);
              else
                {


@@ -4075,8 +4082,6 @@ encode_arm_addr_mode_2 (int i, bfd_boolean is_t)
     {
       if (inst.reloc.type == BFD_RELOC_UNUSED)
        inst.reloc.type = BFD_RELOC_ARM_OFFSET_IMM;
     {
       if (inst.reloc.type == BFD_RELOC_UNUSED)
        inst.reloc.type = BFD_RELOC_ARM_OFFSET_IMM;

-      if (inst.reloc.pc_rel)
-       inst.reloc.exp.X_add_number -= 8;  /* pipeline offset */

     }
 }
 
     }
 }
 


@@ -4107,8 +4112,6 @@ encode_arm_addr_mode_3 (int i, bfd_boolean is_t)
       inst.instruction |= HWOFFSET_IMM;
       if (inst.reloc.type == BFD_RELOC_UNUSED)
        inst.reloc.type = BFD_RELOC_ARM_OFFSET_IMM8;
       inst.instruction |= HWOFFSET_IMM;
       if (inst.reloc.type == BFD_RELOC_UNUSED)
        inst.reloc.type = BFD_RELOC_ARM_OFFSET_IMM8;

-      if (inst.reloc.pc_rel)
-       inst.reloc.exp.X_add_number -= 8;  /* pipeline offset */

     }
 }
 
     }
 }
 


@@ -4161,8 +4164,6 @@ encode_arm_cp_address (int i, int wb_ok, int unind_ok, int reloc_override)
     inst.reloc.type = reloc_override;
   else
     inst.reloc.type = BFD_RELOC_ARM_CP_OFF_IMM;
     inst.reloc.type = reloc_override;
   else
     inst.reloc.type = BFD_RELOC_ARM_CP_OFF_IMM;

-  if (inst.reloc.pc_rel)
-    inst.reloc.exp.X_add_number -= 8;

   return SUCCESS;
 }
 
   return SUCCESS;
 }
 


@@ -4329,10 +4330,8 @@ do_adr (void)
   /* Frag hacking will turn this into a sub instruction if the offset turns
      out to be negative.  */
   inst.reloc.type = BFD_RELOC_ARM_IMMEDIATE;
   /* Frag hacking will turn this into a sub instruction if the offset turns
      out to be negative.  */
   inst.reloc.type = BFD_RELOC_ARM_IMMEDIATE;

-#ifndef TE_WINCE
-  inst.reloc.exp.X_add_number -= 8; /* PC relative adjust.  */
-#endif

   inst.reloc.pc_rel = 1;
   inst.reloc.pc_rel = 1;

+  inst.reloc.exp.X_add_number -= 8;

 }
 
 /* This is a pseudo-op of the form "adrl rd, label" to be converted
 }
 
 /* This is a pseudo-op of the form "adrl rd, label" to be converted


@@ -4348,11 +4347,9 @@ do_adrl (void)
   /* Frag hacking will turn this into a sub instruction if the offset turns
      out to be negative.  */
   inst.reloc.type             = BFD_RELOC_ARM_ADRL_IMMEDIATE;
   /* Frag hacking will turn this into a sub instruction if the offset turns
      out to be negative.  */
   inst.reloc.type             = BFD_RELOC_ARM_ADRL_IMMEDIATE;

-#ifndef TE_WINCE
-  inst.reloc.exp.X_add_number -= 8; /* PC relative adjust  */
-#endif

   inst.reloc.pc_rel           = 1;
   inst.size                   = INSN_SIZE * 2;
   inst.reloc.pc_rel           = 1;
   inst.size                   = INSN_SIZE * 2;

+  inst.reloc.exp.X_add_number -= 8;

 }
 
 static void
 }
 
 static void


@@ -4432,13 +4429,12 @@ encode_branch (int default_reloc)
       constraint (inst.operands[0].imm != BFD_RELOC_ARM_PLT32,
                  _("the only suffix valid here is '(plt)'"));
       inst.reloc.type  = BFD_RELOC_ARM_PLT32;
       constraint (inst.operands[0].imm != BFD_RELOC_ARM_PLT32,
                  _("the only suffix valid here is '(plt)'"));
       inst.reloc.type  = BFD_RELOC_ARM_PLT32;

-      inst.reloc.pc_rel = 0;

     }
   else
     {
       inst.reloc.type = default_reloc;
     }
   else
     {
       inst.reloc.type = default_reloc;

-      inst.reloc.pc_rel = 1;

     }
     }

+  inst.reloc.pc_rel = 1;

 }
 
 static void
 }
 
 static void


@@ -4472,7 +4468,7 @@ do_blx (void)
       /* Arg is an address; this instruction cannot be executed
         conditionally, and the opcode must be adjusted.  */
       constraint (inst.cond != COND_ALWAYS, BAD_COND);
       /* Arg is an address; this instruction cannot be executed
         conditionally, and the opcode must be adjusted.  */
       constraint (inst.cond != COND_ALWAYS, BAD_COND);

-      inst.instruction = 0xfafffffe;
+      inst.instruction = 0xfa000000;

       encode_branch (BFD_RELOC_ARM_PCREL_BLX);
     }
 }
       encode_branch (BFD_RELOC_ARM_PCREL_BLX);
     }
 }


@@ -6128,7 +6124,7 @@ do_t_blx (void)
   else
     {
       /* No register.  This must be BLX(1).  */
   else
     {
       /* No register.  This must be BLX(1).  */

-      inst.instruction = 0xf7ffeffe;
+      inst.instruction = 0xf000e800;

       inst.reloc.type  = BFD_RELOC_THUMB_PCREL_BLX;
       inst.reloc.pc_rel = 1;
     }
       inst.reloc.type  = BFD_RELOC_THUMB_PCREL_BLX;
       inst.reloc.pc_rel = 1;
     }


@@ -6141,13 +6137,13 @@ do_t_branch (void)
     {
       if (inst.cond == COND_ALWAYS)
        {
     {
       if (inst.cond == COND_ALWAYS)
        {

-         inst.instruction = 0xf7ffbffe;
+         inst.instruction = 0xf000b000;

          inst.reloc.type = BFD_RELOC_THUMB_PCREL_BRANCH25;
        }
       else
        {
          assert (inst.cond != 0xF);
          inst.reloc.type = BFD_RELOC_THUMB_PCREL_BRANCH25;
        }
       else
        {
          assert (inst.cond != 0xF);

-         inst.instruction = (inst.cond << 22) | 0xf43faffe;
+         inst.instruction = (inst.cond << 22) | 0xf0008000;

          inst.reloc.type = BFD_RELOC_THUMB_PCREL_BRANCH20;
        }
     }
          inst.reloc.type = BFD_RELOC_THUMB_PCREL_BRANCH20;
        }
     }


@@ -6157,7 +6153,7 @@ do_t_branch (void)
        inst.reloc.type = BFD_RELOC_THUMB_PCREL_BRANCH12;
       else
        {
        inst.reloc.type = BFD_RELOC_THUMB_PCREL_BRANCH12;
       else
        {

-         inst.instruction = 0xd0fe | (inst.cond << 8);
+         inst.instruction = 0xd000 | (inst.cond << 8);

          inst.reloc.type = BFD_RELOC_THUMB_PCREL_BRANCH9;
        }
     }
          inst.reloc.type = BFD_RELOC_THUMB_PCREL_BRANCH9;
        }
     }


@@ -8123,19 +8119,13 @@ static const struct asm_opcode insns[] =
  tC3(ldmfd,    8900000, ldmia,    2, (RRw, REGLST), ldmstm, t_ldmstm),
 
  TCE(swi,      f000000, df00,     1, (EXPi),        swi, t_swi),
  tC3(ldmfd,    8900000, ldmia,    2, (RRw, REGLST), ldmstm, t_ldmstm),
 
  TCE(swi,      f000000, df00,     1, (EXPi),        swi, t_swi),

-#ifdef TE_WINCE
-  /* XXX This is the wrong place to do this.  Think multi-arch.         */
- TCE(b,                a000000, e7fe,       1, (EXPr),     branch, t_branch),
- TCE(bl,       b000000, f7fffffe,   1, (EXPr),     branch, t_branch23),
-#else
- TCE(b,                afffffe, e7fe,       1, (EXPr),     branch, t_branch),
- TCE(bl,       bfffffe, f7fffffe,   1, (EXPr),     branch, t_branch23),
-#endif
+ TCE(b,                a000000, e000,     1, (EXPr),        branch, t_branch),
+ TCE(bl,       b000000, f000f800, 1, (EXPr),        branch, t_branch23),

 
   /* Pseudo ops.  */
 
   /* Pseudo ops.  */

- TCE(adr,      28f0000, 000f,     2, (RR, EXP),    adr,  t_adr),
-  C3(adrl,     28f0000,           2, (RR, EXP),    adrl),
- tCE(nop,      1a00000, nop,      1, (oI255c),     nop,  t_nop),
+ TCE(adr,      28f0000, 000f,     2, (RR, EXP),     adr,  t_adr),
+  C3(adrl,     28f0000,           2, (RR, EXP),     adrl),
+ tCE(nop,      1a00000, nop,      1, (oI255c),      nop,  t_nop),

 
   /* Thumb-compatibility pseudo ops.  */
  tCE(lsl,      1a00000, lsl,      3, (RR, oRR, SH), shift, t_shift),
 
   /* Thumb-compatibility pseudo ops.  */
  tCE(lsl,      1a00000, lsl,      3, (RR, oRR, SH), shift, t_shift),


@@ -8143,7 +8133,7 @@ static const struct asm_opcode insns[] =
  tCE(lsr,      1a00020, lsr,      3, (RR, oRR, SH), shift, t_shift),
  tC3(lsrs,     1b00020, lsrs,     3, (RR, oRR, SH), shift, t_shift),
  tCE(asr,      1a00040, asr,      3, (RR, oRR, SH), shift, t_shift),
  tCE(lsr,      1a00020, lsr,      3, (RR, oRR, SH), shift, t_shift),
  tC3(lsrs,     1b00020, lsrs,     3, (RR, oRR, SH), shift, t_shift),
  tCE(asr,      1a00040, asr,      3, (RR, oRR, SH), shift, t_shift),

- tC3(asrs,     1b00040, asrs,     3, (RR, oRR, SH), shift, t_shift),
+ tC3(asrs,      1b00040, asrs,     3, (RR, oRR, SH), shift, t_shift),

  tCE(ror,      1a00060, ror,      3, (RR, oRR, SH), shift, t_shift),
  tC3(rors,     1b00060, rors,     3, (RR, oRR, SH), shift, t_shift),
  tCE(neg,      2600000, neg,      2, (RR, RR),      rd_rn, t_neg),
  tCE(ror,      1a00060, ror,      3, (RR, oRR, SH), shift, t_shift),
  tC3(rors,     1b00060, rors,     3, (RR, oRR, SH), shift, t_shift),
  tCE(neg,      2600000, neg,      2, (RR, RR),      rd_rn, t_neg),


@@ -8153,7 +8143,7 @@ static const struct asm_opcode insns[] =
 
 #undef THUMB_VARIANT
 #define THUMB_VARIANT ARM_EXT_V6
 
 #undef THUMB_VARIANT
 #define THUMB_VARIANT ARM_EXT_V6

- TCE(cpy,       1a00000, 4600,     2, (RR, RR),          rd_rm, t_cpy),
+ TCE(cpy,       1a00000, 4600,     2, (RR, RR),      rd_rm, t_cpy),

 
  /* V1 instructions with no Thumb analogue prior to V6T2.  */
 #undef THUMB_VARIANT
 
  /* V1 instructions with no Thumb analogue prior to V6T2.  */
 #undef THUMB_VARIANT


@@ -8170,7 +8160,7 @@ static const struct asm_opcode insns[] =
  TC3(strbt,    4600000, f8200e00, 2, (RR, ADDR),    ldstt, t_ldstt),
 
  TC3(stmdb,    9000000, e9100000, 2, (RRw, REGLST), ldmstm, t_ldmstm),
  TC3(strbt,    4600000, f8200e00, 2, (RR, ADDR),    ldstt, t_ldstt),
 
  TC3(stmdb,    9000000, e9100000, 2, (RRw, REGLST), ldmstm, t_ldmstm),

- TC3(stmfd,    9000000, e9100000, 2, (RRw, REGLST), ldmstm, t_ldmstm),
+ TC3(stmfd,     9000000, e9100000, 2, (RRw, REGLST), ldmstm, t_ldmstm),

 
  TC3(ldmdb,    9100000, e9000000, 2, (RRw, REGLST), ldmstm, t_ldmstm),
  TC3(ldmea,    9100000, e9000000, 2, (RRw, REGLST), ldmstm, t_ldmstm),
 
  TC3(ldmdb,    9100000, e9000000, 2, (RRw, REGLST), ldmstm, t_ldmstm),
  TC3(ldmea,    9100000, e9000000, 2, (RRw, REGLST), ldmstm, t_ldmstm),


@@ -9898,41 +9888,75 @@ tc_arm_frame_initial_instructions (void)
 
 /* MD interface: Symbol and relocation handling.  */
 
 
 /* MD interface: Symbol and relocation handling.  */
 

-/* The knowledge of the PC's pipeline offset is built into the insns
-   themselves. */
+/* Return the address within the segment that a PC-relative fixup is
+   relative to.  For ARM, PC-relative fixups applied to instructions
+   are generally relative to the location of the fixup plus 8 bytes.
+   Thumb branches are offset by 4, and Thumb loads relative to PC
+   require special handling.  */

 
 long
 
 long

-md_pcrel_from (fixS * fixP)
+md_pcrel_from_section (fixS * fixP, segT seg)

 {
 {

-  if (fixP->fx_addsy
-      && S_GET_SEGMENT (fixP->fx_addsy) == undefined_section
-      && fixP->fx_subsy == NULL)
-    return 0;
+  offsetT base = fixP->fx_where + fixP->fx_frag->fr_address;
+
+  /* If this is pc-relative and we are going to emit a relocation
+     then we just want to put out any pipeline compensation that the linker
+     will need.  Otherwise we want to use the calculated base.  */
+  if (fixP->fx_pcrel 
+      && ((fixP->fx_addsy && S_GET_SEGMENT (fixP->fx_addsy) != seg)
+         || arm_force_relocation (fixP)))
+    base = 0;

 
 

-  /* PC relative addressing on the Thumb is slightly odd as the bottom
-     two bits of the PC are forced to zero for the calculation.  This
-     happens *after* application of the pipeline offset.  However,
-     Thumb adrl already adjusts for this, so we need not do it again.  */

   switch (fixP->fx_r_type)
     {
   switch (fixP->fx_r_type)
     {

+      /* PC relative addressing on the Thumb is slightly odd as the
+        bottom two bits of the PC are forced to zero for the
+        calculation.  This happens *after* application of the
+        pipeline offset.  However, Thumb adrl already adjusts for
+        this, so we need not do it again.  */

     case BFD_RELOC_ARM_THUMB_ADD:
     case BFD_RELOC_ARM_THUMB_ADD:

-      return (fixP->fx_where + fixP->fx_frag->fr_address) & ~3;
+      return base & ~3;

 
     case BFD_RELOC_ARM_THUMB_OFFSET:
     case BFD_RELOC_ARM_T32_OFFSET_IMM:
 
     case BFD_RELOC_ARM_THUMB_OFFSET:
     case BFD_RELOC_ARM_T32_OFFSET_IMM:

-      return (fixP->fx_where + fixP->fx_frag->fr_address + 4) & ~3;
+      return (base + 4) & ~3;

 
 

-    default:
-      break;
-    }
+      /* Thumb branches are simply offset by +4.  */
+    case BFD_RELOC_THUMB_PCREL_BRANCH7:
+    case BFD_RELOC_THUMB_PCREL_BRANCH9:
+    case BFD_RELOC_THUMB_PCREL_BRANCH12:
+    case BFD_RELOC_THUMB_PCREL_BRANCH20:
+    case BFD_RELOC_THUMB_PCREL_BRANCH23:
+    case BFD_RELOC_THUMB_PCREL_BRANCH25:
+    case BFD_RELOC_THUMB_PCREL_BLX:
+      return base + 4;

 
 

+      /* ARM mode branches are offset by +8.  However, the Windows CE
+        loader expects the relocation not to take this into account.  */
+    case BFD_RELOC_ARM_PCREL_BRANCH:
+    case BFD_RELOC_ARM_PCREL_BLX:
+    case BFD_RELOC_ARM_PLT32:

 #ifdef TE_WINCE
 #ifdef TE_WINCE

-  /* The pattern was adjusted to accommodate CE's off-by-one fixups,
-     so we un-adjust here to compensate for the accommodation. */
-  return fixP->fx_where + fixP->fx_frag->fr_address + 8;
+      return base;

 #else
 #else

-  return fixP->fx_where + fixP->fx_frag->fr_address;
+      return base + 8;

 #endif
 #endif

+
+      /* ARM mode loads relative to PC are also offset by +8.  Unlike
+        branches, the Windows CE loader *does* expect the relocation
+        to take this into account.  */
+    case BFD_RELOC_ARM_OFFSET_IMM:
+    case BFD_RELOC_ARM_OFFSET_IMM8:
+    case BFD_RELOC_ARM_HWLITERAL:
+    case BFD_RELOC_ARM_LITERAL:
+    case BFD_RELOC_ARM_CP_OFF_IMM:
+      return base + 8;
+
+
+      /* Other PC-relative relocations are un-offset.  */
+    default:
+      return base;
+    }

 }
 
 /* Under ELF we need to default _GLOBAL_OFFSET_TABLE.
 }
 
 /* Under ELF we need to default _GLOBAL_OFFSET_TABLE.


@@ -10115,17 +10139,6 @@ md_apply_fix (fixS *   fixP,
   if (fixP->fx_addsy == 0 && !fixP->fx_pcrel)
     fixP->fx_done = 1;
 
   if (fixP->fx_addsy == 0 && !fixP->fx_pcrel)
     fixP->fx_done = 1;
 

-  /* If this symbol is in a different section then we need to leave it for
-     the linker to deal with.  Unfortunately, md_pcrel_from can't tell,
-     so we have to undo its effects here.  */
-  if (fixP->fx_pcrel)
-    {
-      if (fixP->fx_addsy != NULL
-         && S_IS_DEFINED (fixP->fx_addsy)
-         && S_GET_SEGMENT (fixP->fx_addsy) != seg)
-       value += md_pcrel_from (fixP);
-    }
-

   /* On a 64-bit host, silently truncate 'value' to 32 bits for
      consistency with the behavior on 32-bit hosts.  Remember value
      for emit_reloc.  */
   /* On a 64-bit host, silently truncate 'value' to 32 bits for
      consistency with the behavior on 32-bit hosts.  Remember value
      for emit_reloc.  */


@@ -10286,7 +10299,6 @@ md_apply_fix (fixS *    fixP,
       value /= 4;
 
       newval = md_chars_to_number (buf+2, THUMB_SIZE);
       value /= 4;
 
       newval = md_chars_to_number (buf+2, THUMB_SIZE);

-      newval &= 0xff00;

       newval |= value;
       md_number_to_chars (buf+2, newval, THUMB_SIZE);
       break;
       newval |= value;
       md_number_to_chars (buf+2, newval, THUMB_SIZE);
       break;


@@ -10457,7 +10469,6 @@ md_apply_fix (fixS *    fixP,
          break;
        }
 
          break;
        }
 

-      newval &= 0xfbff8f00;

       newval |= (newimm & 0x800) << 15;
       newval |= (newimm & 0x700) << 4;
       newval |= (newimm & 0x0ff);
       newval |= (newimm & 0x800) << 15;
       newval |= (newimm & 0x700) << 4;
       newval |= (newimm & 0x0ff);


@@ -10470,7 +10481,7 @@ md_apply_fix (fixS *    fixP,
       if (((unsigned long) value) > 0xffff)
        as_bad_where (fixP->fx_file, fixP->fx_line,
                      _("invalid smi expression"));
       if (((unsigned long) value) > 0xffff)
        as_bad_where (fixP->fx_file, fixP->fx_line,
                      _("invalid smi expression"));

-      newval = md_chars_to_number (buf, INSN_SIZE) & 0xfff000f0;
+      newval = md_chars_to_number (buf, INSN_SIZE);

       newval |= (value & 0xf) | ((value & 0xfff0) << 4);
       md_number_to_chars (buf, newval, INSN_SIZE);
       break;
       newval |= (value & 0xf) | ((value & 0xfff0) << 4);
       md_number_to_chars (buf, newval, INSN_SIZE);
       break;


@@ -10481,7 +10492,7 @@ md_apply_fix (fixS *    fixP,
          if (((unsigned long) value) > 0xff)
            as_bad_where (fixP->fx_file, fixP->fx_line,
                          _("invalid swi expression"));
          if (((unsigned long) value) > 0xff)
            as_bad_where (fixP->fx_file, fixP->fx_line,
                          _("invalid swi expression"));

-         newval = md_chars_to_number (buf, THUMB_SIZE) & 0xff00;
+         newval = md_chars_to_number (buf, THUMB_SIZE);

          newval |= value;
          md_number_to_chars (buf, newval, THUMB_SIZE);
        }
          newval |= value;
          md_number_to_chars (buf, newval, THUMB_SIZE);
        }


@@ -10490,7 +10501,7 @@ md_apply_fix (fixS *    fixP,
          if (((unsigned long) value) > 0x00ffffff)
            as_bad_where (fixP->fx_file, fixP->fx_line,
                          _("invalid swi expression"));
          if (((unsigned long) value) > 0x00ffffff)
            as_bad_where (fixP->fx_file, fixP->fx_line,
                          _("invalid swi expression"));

-         newval = md_chars_to_number (buf, INSN_SIZE) & 0xff000000;
+         newval = md_chars_to_number (buf, INSN_SIZE);

          newval |= value;
          md_number_to_chars (buf, newval, INSN_SIZE);
        }
          newval |= value;
          md_number_to_chars (buf, newval, INSN_SIZE);
        }


@@ -10505,358 +10516,180 @@ md_apply_fix (fixS *        fixP,
       break;
 
     case BFD_RELOC_ARM_PCREL_BRANCH:
       break;
 
     case BFD_RELOC_ARM_PCREL_BRANCH:

-      newval = md_chars_to_number (buf, INSN_SIZE);
-
-      /* Sign-extend a 24-bit number.  */
-#define SEXT24(x)      ((((x) & 0xffffff) ^ (~ 0x7fffff)) + 0x800000)
-

 #ifdef OBJ_ELF
 #ifdef OBJ_ELF

-      if (!fixP->fx_done)
-       value = fixP->fx_offset;
+    case BFD_RELOC_ARM_PLT32:

 #endif
 
       /* We are going to store value (shifted right by two) in the
 #endif
 
       /* We are going to store value (shifted right by two) in the

-        instruction, in a 24 bit, signed field  Thus we need to check
-        that none of the top 8 bits of the shifted value (top 7 bits of
-        the unshifted, unsigned value) are set, or that they are all set.  */
-      if ((value & ~ ((offsetT) 0x1ffffff)) != 0
-         && ((value & ~ ((offsetT) 0x1ffffff)) != ~ ((offsetT) 0x1ffffff)))
-       {
-#ifdef OBJ_ELF
-         /* Normally we would be stuck at this point, since we cannot store
-            the absolute address that is the destination of the branch in the
-            24 bits of the branch instruction.  If however, we happen to know
-            that the destination of the branch is in the same section as the
-            branch instruction itself, then we can compute the relocation for
-            ourselves and not have to bother the linker with it.
-
-            FIXME: The test for OBJ_ELF is only here because I have not
-            worked out how to do this for OBJ_COFF.  */
-         if (fixP->fx_addsy != NULL
-             && S_IS_DEFINED (fixP->fx_addsy)
-             && S_GET_SEGMENT (fixP->fx_addsy) == seg)
-           {
-             /* Get pc relative value to go into the branch.  */
-             value = * valP;
-
-             /* Permit a backward branch provided that enough bits
-                are set.  Allow a forwards branch, provided that
-                enough bits are clear.  */
-             if (   (value & ~ ((offsetT) 0x1ffffff)) == ~ ((offsetT) 0x1ffffff)
-                 || (value & ~ ((offsetT) 0x1ffffff)) == 0)
-               fixP->fx_done = 1;
-           }
-
-         if (! fixP->fx_done)
-#endif
-           as_bad_where (fixP->fx_file, fixP->fx_line,
-                         _("GAS can't handle same-section branch dest >= 0x04000000"));
-       }
-
-      value >>= 2;
-      value += SEXT24 (newval);
-
-      if (    (value & ~ ((offsetT) 0xffffff)) != 0
-         && ((value & ~ ((offsetT) 0xffffff)) != ~ ((offsetT) 0xffffff)))
+        instruction, in a 24 bit, signed field.  Bits 0 and 1 must be
+        clear, and bits 26 through 32 either all clear or all set. */
+      if (value & 0x00000003)
+       as_bad_where (fixP->fx_file, fixP->fx_line,
+                     _("misaligned branch destination"));
+      if ((value & (offsetT)0xfe000000) != (offsetT)0
+         && (value & (offsetT)0xfe000000) != (offsetT)0xfe000000)

        as_bad_where (fixP->fx_file, fixP->fx_line,
        as_bad_where (fixP->fx_file, fixP->fx_line,

-                     _("out of range branch"));
+                     _("branch out of range"));

 
 

-      if (seg->use_rela_p && !fixP->fx_done)
+      if (fixP->fx_done || !seg->use_rela_p)

        {
        {

-         /* Must unshift the value before storing it in the addend.  */
-         value <<= 2;
-#ifdef OBJ_ELF
-         fixP->fx_offset = value;
-#endif
-         fixP->fx_addnumber = value;
-         newval = newval & 0xff000000;
+         newval = md_chars_to_number (buf, INSN_SIZE);
+         newval |= (value >> 2) & 0x00ffffff;
+         md_number_to_chars (buf, newval, INSN_SIZE);

        }
        }

-      else
-         newval = (value & 0x00ffffff) | (newval & 0xff000000);
-      md_number_to_chars (buf, newval, INSN_SIZE);

       break;
 
     case BFD_RELOC_ARM_PCREL_BLX:
       break;
 
     case BFD_RELOC_ARM_PCREL_BLX:

-      {
-       offsetT hbit;
-       newval = md_chars_to_number (buf, INSN_SIZE);
+      /* BLX allows bit 1 to be set in the branch destination, since
+        it targets a Thumb instruction which is only required to be
+        aligned modulo 2.  Other constraints are as for B/BL.  */
+      if (value & 0x00000001)
+       as_bad_where (fixP->fx_file, fixP->fx_line,
+                     _("misaligned BLX destination"));
+      if ((value & (offsetT)0xfe000000) != (offsetT)0
+         && (value & (offsetT)0xfe000000) != (offsetT)0xfe000000)
+       as_bad_where (fixP->fx_file, fixP->fx_line,
+                     _("branch out of range"));

 
 

-#ifdef OBJ_ELF
-       if (!fixP->fx_done)
-         value = fixP->fx_offset;
-#endif
-       hbit   = (value >> 1) & 1;
-       value  = (value >> 2) & 0x00ffffff;
-       value  = (value + (newval & 0x00ffffff)) & 0x00ffffff;
+      if (fixP->fx_done || !seg->use_rela_p)
+       {
+         offsetT hbit;
+         hbit   = (value >> 1) & 1;
+         value  = (value >> 2) & 0x00ffffff;

 
 

-       if (seg->use_rela_p && !fixP->fx_done)
-         {
-           /* Must sign-extend and unshift the value before storing
-              it in the addend.  */
-           value = SEXT24 (value);
-           value = (value << 2) | hbit;
-#ifdef OBJ_ELF
-           fixP->fx_offset = value;
-#endif
-           fixP->fx_addnumber = value;
-           newval = newval & 0xfe000000;
-         }
-       else
-         newval = value | (newval & 0xfe000000) | (hbit << 24);
-       md_number_to_chars (buf, newval, INSN_SIZE);
-      }
+         newval = md_chars_to_number (buf, INSN_SIZE);
+         newval |= value | hbit << 24;
+         md_number_to_chars (buf, newval, INSN_SIZE);
+       }

       break;
 
     case BFD_RELOC_THUMB_PCREL_BRANCH7: /* CZB */
       break;
 
     case BFD_RELOC_THUMB_PCREL_BRANCH7: /* CZB */

-      newval = md_chars_to_number (buf, THUMB_SIZE);
-      {
-       addressT diff = ((newval & 0x00f8) >> 2) | (newval & 0x0200) >> 3;
-       /* This one does not have the offset encoded in the pattern.  */
-       value = value + diff - 4;
-       /* CZB can only branch forward.  */
-       if (value & ~0x7e)
-         as_bad_where (fixP->fx_file, fixP->fx_line,
-                       _("branch out of range"));
+      /* CZB can only branch forward.  */
+      if (value & ~0x7e)
+       as_bad_where (fixP->fx_file, fixP->fx_line,
+                     _("branch out of range"));

 
 

-       newval &= 0xfd07;
-       if (seg->use_rela_p && !fixP->fx_done)
-         {
-#ifdef OBJ_ELF
-           fixP->fx_offset = value;
-#endif
-           fixP->fx_addnumber = value;
-         }
-       else
+      if (fixP->fx_done || !seg->use_rela_p)
+       {
+         newval = md_chars_to_number (buf, THUMB_SIZE);

          newval |= ((value & 0x2e) << 2) | ((value & 0x40) << 3);
          newval |= ((value & 0x2e) << 2) | ((value & 0x40) << 3);

-      }
-      md_number_to_chars (buf, newval, THUMB_SIZE);
+         md_number_to_chars (buf, newval, THUMB_SIZE);
+       }

       break;
 
     case BFD_RELOC_THUMB_PCREL_BRANCH9: /* Conditional branch. */
       break;
 
     case BFD_RELOC_THUMB_PCREL_BRANCH9: /* Conditional branch. */

-      newval = md_chars_to_number (buf, THUMB_SIZE);
-      {
-       addressT diff = (newval & 0xff) << 1;
-       if (diff & 0x100)
-         diff |= ~0xff;
+      if ((value & ~0xff) && ((value & ~0xff) != ~0xff))
+       as_bad_where (fixP->fx_file, fixP->fx_line,
+                     _("branch out of range"));

 
 

-       value += diff;
-       if ((value & ~0xff) && ((value & ~0xff) != ~0xff))
-         as_bad_where (fixP->fx_file, fixP->fx_line,
-                       _("branch out of range"));
-       if (seg->use_rela_p && !fixP->fx_done)
-         {
-#ifdef OBJ_ELF
-           fixP->fx_offset = value;
-#endif
-           fixP->fx_addnumber = value;
-           newval = newval & 0xff00;
-         }
-       else
-         newval = (newval & 0xff00) | ((value & 0x1ff) >> 1);
-      }
-      md_number_to_chars (buf, newval, THUMB_SIZE);
+      if (fixP->fx_done || !seg->use_rela_p)
+       {
+         newval = md_chars_to_number (buf, THUMB_SIZE);
+         newval |= (value & 0x1ff) >> 1;
+         md_number_to_chars (buf, newval, THUMB_SIZE);
+       }

       break;
 
     case BFD_RELOC_THUMB_PCREL_BRANCH12: /* Unconditional branch.  */
       break;
 
     case BFD_RELOC_THUMB_PCREL_BRANCH12: /* Unconditional branch.  */

-      newval = md_chars_to_number (buf, THUMB_SIZE);
-      {
-       addressT diff = (newval & 0x7ff) << 1;
-       if (diff & 0x800)
-         diff |= ~0x7ff;
+      if ((value & ~0x7ff) && ((value & ~0x7ff) != ~0x7ff))
+       as_bad_where (fixP->fx_file, fixP->fx_line,
+                     _("branch out of range"));

 
 

-       value += diff;
-       if ((value & ~0x7ff) && ((value & ~0x7ff) != ~0x7ff))
-         as_bad_where (fixP->fx_file, fixP->fx_line,
-                       _("branch out of range"));
-       if (seg->use_rela_p && !fixP->fx_done)
-         {
-#ifdef OBJ_ELF
-           fixP->fx_offset = value;
-#endif
-           fixP->fx_addnumber = value;
-           newval = newval & 0xf800;
-         }
-       else
-         newval = (newval & 0xf800) | ((value & 0xfff) >> 1);
-      }
-      md_number_to_chars (buf, newval, THUMB_SIZE);
+      if (fixP->fx_done || !seg->use_rela_p)
+       {
+         newval = md_chars_to_number (buf, THUMB_SIZE);
+         newval |= (value & 0xfff) >> 1;
+         md_number_to_chars (buf, newval, THUMB_SIZE);
+       }

       break;
 
     case BFD_RELOC_THUMB_PCREL_BRANCH20:
       break;
 
     case BFD_RELOC_THUMB_PCREL_BRANCH20:

-      {
-       offsetT newval2;
-       addressT diff, S, J1, J2, lo, hi;
-
-       newval  = md_chars_to_number (buf, THUMB_SIZE);
-       newval2 = md_chars_to_number (buf + THUMB_SIZE, THUMB_SIZE);
-
-       S  = !(newval & 0x0400);  /* flipped - 0=negative */
-       hi = (newval  & 0x003f);
-       J1 = (newval2 & 0x2000) >> 13;
-       J2 = (newval2 & 0x0800) >> 11;
-       lo = (newval2 & 0x07ff);
-
-       diff = ((S << 20) | (J2 << 19) | (J1 << 18) | (hi << 12) | (lo << 1));
-       diff -= (1 << 20);  /* sign extend */
-       value += diff;
+      if ((value & ~0x1fffff) && ((value & ~0x1fffff) != ~0x1fffff))
+       as_bad_where (fixP->fx_file, fixP->fx_line,
+                     _("conditional branch out of range"));

 
 

-       if ((value & ~0x1fffff) && ((value & ~0x1fffff) != ~0x1fffff))
-         as_bad_where (fixP->fx_file, fixP->fx_line,
-                       _("conditional branch out of range"));
+      if (fixP->fx_done || !seg->use_rela_p)
+       {
+         offsetT newval2;
+         addressT S, J1, J2, lo, hi;

 
 

-       newval  = newval  & 0xfbc0;
-       newval2 = newval2 & 0xd000;
-       if (seg->use_rela_p && !fixP->fx_done)
-         {
-#ifdef OBJ_ELF
-           fixP->fx_offset = value;
-#endif
-           fixP->fx_addnumber = value;
-         }
-       else
-         {
-           S  = (value & 0x00100000) >> 20;
-           J2 = (value & 0x00080000) >> 19;
-           J1 = (value & 0x00040000) >> 18;
-           hi = (value & 0x0003f000) >> 12;
-           lo = (value & 0x00000ffe) >> 1;
-
-           newval  = newval  | (S << 10) | hi;
-           newval2 = newval2 | (J1 << 13) | (J2 << 11) | lo;
-         }
+         S  = (value & 0x00100000) >> 20;
+         J2 = (value & 0x00080000) >> 19;
+         J1 = (value & 0x00040000) >> 18;
+         hi = (value & 0x0003f000) >> 12;
+         lo = (value & 0x00000ffe) >> 1;

 
 

-       md_number_to_chars (buf, newval, THUMB_SIZE);
-       md_number_to_chars (buf + THUMB_SIZE, newval2, THUMB_SIZE);
-      }
+         newval   = md_chars_to_number (buf, THUMB_SIZE);
+         newval2  = md_chars_to_number (buf + THUMB_SIZE, THUMB_SIZE);
+         newval  |= (S << 10) | hi;
+         newval2 |= (J1 << 13) | (J2 << 11) | lo;
+         md_number_to_chars (buf, newval, THUMB_SIZE);
+         md_number_to_chars (buf + THUMB_SIZE, newval2, THUMB_SIZE);
+       }

       break;
 
     case BFD_RELOC_THUMB_PCREL_BLX:
     case BFD_RELOC_THUMB_PCREL_BRANCH23:
       break;
 
     case BFD_RELOC_THUMB_PCREL_BLX:
     case BFD_RELOC_THUMB_PCREL_BRANCH23:

-      {
-       offsetT newval2;
-       addressT diff;
-
-       newval  = md_chars_to_number (buf, THUMB_SIZE);
-       newval2 = md_chars_to_number (buf + THUMB_SIZE, THUMB_SIZE);
-       diff = ((newval & 0x7ff) << 12) | ((newval2 & 0x7ff) << 1);
-       if (diff & 0x400000)
-         diff |= ~0x3fffff;
-#ifdef OBJ_ELF
-       if (!fixP->fx_done)
-         value = fixP->fx_offset;
-#endif
-       value += diff;
-
-       if ((value & ~0x3fffff) && ((value & ~0x3fffff) != ~0x3fffff))
-         as_bad_where (fixP->fx_file, fixP->fx_line,
-                       _("branch with link out of range"));
-
-       if (fixP->fx_r_type == BFD_RELOC_THUMB_PCREL_BLX)
-         /* For a BLX instruction, make sure that the relocation is rounded up
-            to a word boundary.  This follows the semantics of the instruction
-            which specifies that bit 1 of the target address will come from bit
-            1 of the base address.  */
-         value = (value + 1) & ~ 1;
+      if ((value & ~0x3fffff) && ((value & ~0x3fffff) != ~0x3fffff))
+       as_bad_where (fixP->fx_file, fixP->fx_line,
+                     _("branch out of range"));

 
 

-       if (seg->use_rela_p && !fixP->fx_done)
-         {
-#ifdef OBJ_ELF
-           fixP->fx_offset = value;
-#endif
-           fixP->fx_addnumber = value;
-           newval = newval & 0xf800;
-           newval2 = newval2 & 0xf800;
-         }
-       else
-         {
-           newval  = (newval  & 0xf800) | ((value & 0x7fffff) >> 12);
-           newval2 = (newval2 & 0xf800) | ((value & 0xfff) >> 1);
-         }
-       md_number_to_chars (buf, newval, THUMB_SIZE);
-       md_number_to_chars (buf + THUMB_SIZE, newval2, THUMB_SIZE);
-      }
-      break;
+      if (fixP->fx_r_type == BFD_RELOC_THUMB_PCREL_BLX)
+       /* For a BLX instruction, make sure that the relocation is rounded up
+          to a word boundary.  This follows the semantics of the instruction
+          which specifies that bit 1 of the target address will come from bit
+          1 of the base address.  */
+       value = (value + 1) & ~ 1;

 
 

-    case BFD_RELOC_8:
-      if (seg->use_rela_p && !fixP->fx_done)
-       break;
-      if (fixP->fx_done || fixP->fx_pcrel)
-       md_number_to_chars (buf, value, 1);
-#ifdef OBJ_ELF
-      else
+      if (fixP->fx_done || !seg->use_rela_p)

        {
        {

-         value = fixP->fx_offset;
-         md_number_to_chars (buf, value, 1);
+         offsetT newval2;
+
+         newval   = md_chars_to_number (buf, THUMB_SIZE);
+         newval2  = md_chars_to_number (buf + THUMB_SIZE, THUMB_SIZE);
+         newval  |= (value & 0x7fffff) >> 12;
+         newval2 |= (value & 0xfff) >> 1;
+         md_number_to_chars (buf, newval, THUMB_SIZE);
+         md_number_to_chars (buf + THUMB_SIZE, newval2, THUMB_SIZE);

        }
        }

-#endif

       break;
 
     case BFD_RELOC_THUMB_PCREL_BRANCH25:
       break;
 
     case BFD_RELOC_THUMB_PCREL_BRANCH25:

-      {
-       offsetT newval2;
-       addressT diff, S, I1, I2, lo, hi;
-
-       newval  = md_chars_to_number (buf, THUMB_SIZE);
-       newval2 = md_chars_to_number (buf + THUMB_SIZE, THUMB_SIZE);
-
-       S  = (newval  & 0x0400) >> 10;
-       hi = (newval  & 0x03ff);
-       I1 = (newval2 & 0x2000) >> 13;
-       I2 = (newval2 & 0x0800) >> 11;
-       lo = (newval2 & 0x07ff);
-
-       I1 = !(I1 ^ S);
-       I2 = !(I2 ^ S);
-       S  = !S;
+      if ((value & ~0x1ffffff) && ((value & ~0x1ffffff) != ~0x1ffffff))
+       as_bad_where (fixP->fx_file, fixP->fx_line,
+                     _("branch out of range"));

 
 

-       diff = ((S << 24) | (I1 << 23) | (I2 << 22) | (hi << 12) | (lo << 1));
-       diff -= (1 << 24);  /* sign extend */
-       value += diff;
+      if (fixP->fx_done || !seg->use_rela_p)
+       {
+         offsetT newval2;
+         addressT S, I1, I2, lo, hi;

 
 

-       if ((value & ~0x1ffffff) && ((value & ~0x1ffffff) != ~0x1ffffff))
-         as_bad_where (fixP->fx_file, fixP->fx_line,
-                       _("branch out of range"));
+         S  = (value & 0x01000000) >> 24;
+         I1 = (value & 0x00800000) >> 23;
+         I2 = (value & 0x00400000) >> 22;
+         hi = (value & 0x003ff000) >> 12;
+         lo = (value & 0x00000ffe) >> 1;

 
 

-       newval  = newval  & 0xf800;
-       newval2 = newval2 & 0xd000;
-       if (seg->use_rela_p && !fixP->fx_done)
-         {
-#ifdef OBJ_ELF
-           fixP->fx_offset = value;
-#endif
-           fixP->fx_addnumber = value;
-         }
-       else
-         {
-           S  = (value & 0x01000000) >> 24;
-           I1 = (value & 0x00800000) >> 23;
-           I2 = (value & 0x00400000) >> 22;
-           hi = (value & 0x003ff000) >> 12;
-           lo = (value & 0x00000ffe) >> 1;
+         I1 = !(I1 ^ S);
+         I2 = !(I2 ^ S);

 
 

-           I1 = !(I1 ^ S);
-           I2 = !(I2 ^ S);
+         newval   = md_chars_to_number (buf, THUMB_SIZE);
+         newval2  = md_chars_to_number (buf + THUMB_SIZE, THUMB_SIZE);
+         newval  |= (S << 10) | hi;
+         newval2 |= (I1 << 13) | (I2 << 11) | lo;
+         md_number_to_chars (buf, newval, THUMB_SIZE);
+         md_number_to_chars (buf + THUMB_SIZE, newval2, THUMB_SIZE);
+       }
+      break;

 
 

-           newval  = newval  | (S << 10) | hi;
-           newval2 = newval2 | (I1 << 13) | (I2 << 11) | lo;
-         }
-       md_number_to_chars (buf, newval, THUMB_SIZE);
-       md_number_to_chars (buf + THUMB_SIZE, newval2, THUMB_SIZE);
-      }
+    case BFD_RELOC_8:
+      if (fixP->fx_done || !seg->use_rela_p)
+       md_number_to_chars (buf, value, 1);

       break;
 
     case BFD_RELOC_16:
       break;
 
     case BFD_RELOC_16:

-      if (seg->use_rela_p && !fixP->fx_done)
-       break;
-      if (fixP->fx_done || fixP->fx_pcrel)
+      if (fixP->fx_done || !seg->use_rela_p)

        md_number_to_chars (buf, value, 2);
        md_number_to_chars (buf, value, 2);

-#ifdef OBJ_ELF
-      else
-       {
-         value = fixP->fx_offset;
-         md_number_to_chars (buf, value, 2);
-       }
-#endif

       break;
 
 #ifdef OBJ_ELF
       break;
 
 #ifdef OBJ_ELF


@@ -10871,9 +10704,8 @@ md_apply_fix (fixS *    fixP,
     case BFD_RELOC_ARM_GOT32:
     case BFD_RELOC_ARM_GOTOFF:
     case BFD_RELOC_ARM_TARGET2:
     case BFD_RELOC_ARM_GOT32:
     case BFD_RELOC_ARM_GOTOFF:
     case BFD_RELOC_ARM_TARGET2:

-      if (seg->use_rela_p && !fixP->fx_done)
-       break;
-      md_number_to_chars (buf, 0, 4);
+      if (fixP->fx_done || !seg->use_rela_p)
+       md_number_to_chars (buf, 0, 4);

       break;
 #endif
 
       break;
 #endif
 


@@ -10883,22 +10715,13 @@ md_apply_fix (fixS *  fixP,
     case BFD_RELOC_ARM_ROSEGREL32:
     case BFD_RELOC_ARM_SBREL32:
     case BFD_RELOC_32_PCREL:
     case BFD_RELOC_ARM_ROSEGREL32:
     case BFD_RELOC_ARM_SBREL32:
     case BFD_RELOC_32_PCREL:

-      if (seg->use_rela_p && !fixP->fx_done)
-       break;
-      if (fixP->fx_done || fixP->fx_pcrel)
+      if (fixP->fx_done || !seg->use_rela_p)

        md_number_to_chars (buf, value, 4);
        md_number_to_chars (buf, value, 4);

-#ifdef OBJ_ELF
-      else
-       {
-         value = fixP->fx_offset;
-         md_number_to_chars (buf, value, 4);
-       }
-#endif

       break;
 
 #ifdef OBJ_ELF
     case BFD_RELOC_ARM_PREL31:
       break;
 
 #ifdef OBJ_ELF
     case BFD_RELOC_ARM_PREL31:

-      if (fixP->fx_done || fixP->fx_pcrel)
+      if (fixP->fx_done || !seg->use_rela_p)

        {
          newval = md_chars_to_number (buf, 4) & 0x80000000;
          if ((value ^ (value >> 1)) & 0x40000000)
        {
          newval = md_chars_to_number (buf, 4) & 0x80000000;
          if ((value ^ (value >> 1)) & 0x40000000)


@@ -10910,10 +10733,6 @@ md_apply_fix (fixS *   fixP,
          md_number_to_chars (buf, newval, 4);
        }
       break;
          md_number_to_chars (buf, newval, 4);
        }
       break;

-
-    case BFD_RELOC_ARM_PLT32:
-      /* It appears the instruction is fully prepared at this point.  */
-      break;

 #endif
 
     case BFD_RELOC_ARM_CP_OFF_IMM:
 #endif
 
     case BFD_RELOC_ARM_CP_OFF_IMM:


@@ -11135,15 +10954,9 @@ tc_gen_reloc (asection * section ATTRIBUTE_UNUSED,
   *reloc->sym_ptr_ptr = symbol_get_bfdsym (fixp->fx_addsy);
   reloc->address = fixp->fx_frag->fr_address + fixp->fx_where;
 
   *reloc->sym_ptr_ptr = symbol_get_bfdsym (fixp->fx_addsy);
   reloc->address = fixp->fx_frag->fr_address + fixp->fx_where;
 

-  /* @@ Why fx_addnumber sometimes and fx_offset other times?  */
-#ifndef OBJ_ELF
-  if (fixp->fx_pcrel == 0)
-    reloc->addend = fixp->fx_offset;
-  else
-    reloc->addend = fixp->fx_offset = reloc->address;
-#else  /* OBJ_ELF */
+  if (fixp->fx_pcrel)
+    fixp->fx_offset = reloc->address;

   reloc->addend = fixp->fx_offset;
   reloc->addend = fixp->fx_offset;

-#endif

 
   switch (fixp->fx_r_type)
     {
 
   switch (fixp->fx_r_type)
     {

diff --git a/gas/config/tc-arm.h b/gas/config/tc-arm.h
index c17d176..e692f52 100644 (file)
--- a/gas/config/tc-arm.h
+++ b/gas/config/tc-arm.h
@@ -211,6 +211,9 @@ struct arm_segment_info_type
 
 #endif
 
 
 #endif
 

+#define MD_PCREL_FROM_SECTION(F,S) md_pcrel_from_section(F,S)
+
+extern long md_pcrel_from_section (struct fix *, segT);

 extern void arm_frag_align_code (int, int);
 extern void arm_validate_fix (struct fix *);
 extern const char * elf32_arm_target_format (void);
 extern void arm_frag_align_code (int, int);
 extern void arm_validate_fix (struct fix *);
 extern const char * elf32_arm_target_format (void);

diff --git a/gas/testsuite/ChangeLog b/gas/testsuite/ChangeLog
index 3340bfb..8c85048 100644 (file)
--- a/gas/testsuite/ChangeLog
+++ b/gas/testsuite/ChangeLog
@@ -1,3 +1,10 @@
+2005-06-30  Zack Weinberg  <zack@codesourcery.com>
+
+       * gas/arm/arm.exp: Don't special case ldconst, arm7t, or copro
+       for *-wince-*.
+       * gas/arm/wince_arm7t.d, gas/arm/wince_copro.d
+       * gas/arm/wince_ldconst.d: Delete.
+

 2005-06-20  H.J. Lu  <hongjiu.lu@intel.com>
 
        PR 1013
 2005-06-20  H.J. Lu  <hongjiu.lu@intel.com>
 
        PR 1013

diff --git a/gas/testsuite/gas/arm/arm.exp b/gas/testsuite/gas/arm/arm.exp
index 5fb82ad..123b813 100644 (file)
--- a/gas/testsuite/gas/arm/arm.exp
+++ b/gas/testsuite/gas/arm/arm.exp
@@ -18,16 +18,13 @@ if {[istarget *arm*-*-*] || [istarget "xscale-*-*"]} then {
 
     if {[istarget *-wince-*]} then {
        run_dump_test "wince_inst"
 
     if {[istarget *-wince-*]} then {
        run_dump_test "wince_inst"

-       run_dump_test "wince_ldconst"
-       run_dump_test "wince_arm7t"
-       run_dump_test "wince_copro"

     } else {
        run_dump_test "inst"
     } else {
        run_dump_test "inst"

-       run_dump_test "ldconst"
-       run_dump_test "arm7t"
-       run_dump_test "copro"

     }
 
     }
 

+    run_dump_test "ldconst"
+    run_dump_test "arm7t"
+    run_dump_test "copro"

     run_dump_test "arm3"
     run_dump_test "arm6"
     run_dump_test "arm7dm"
     run_dump_test "arm3"
     run_dump_test "arm6"
     run_dump_test "arm7dm"

diff --git a/gas/testsuite/gas/arm/pic.d b/gas/testsuite/gas/arm/pic.d
index 5a87262..e50a716 100644 (file)
--- a/gas/testsuite/gas/arm/pic.d
+++ b/gas/testsuite/gas/arm/pic.d
@@ -8,7 +8,7 @@
 Disassembly of section .text:
 00+0 <[^>]*> eb......  bl      00+. <[^>]*>
                        0: R_ARM_PC24   foo.*
 Disassembly of section .text:
 00+0 <[^>]*> eb......  bl      00+. <[^>]*>
                        0: R_ARM_PC24   foo.*

-00+4 <[^>]*> ebfffffe  bl      0[0123456789abcdef]+ <[^>]*>
+00+4 <[^>]*> eb......  bl      0[0123456789abcdef]+ <[^>]*>

                        4: R_ARM_PLT32  foo
        \.\.\.
                        8: R_ARM_ABS32  sym
                        4: R_ARM_PLT32  foo
        \.\.\.
                        8: R_ARM_ABS32  sym

diff --git a/gas/testsuite/gas/arm/wince_arm7t.d b/gas/testsuite/gas/arm/wince_arm7t.d
deleted file mode 100644 (file)
index 9d9b87f..0000000
--- a/gas/testsuite/gas/arm/wince_arm7t.d
+++ /dev/null
@@ -1,75 +0,0 @@
-#objdump: -Dr --prefix-addresses --show-raw-insn
-#name: ARM arm7t (WinCE version)
-#as: -mcpu=arm7t -EL
-#source: arm7t.s
-
-# This file is the same as arm7t.d except that the PC-relative
-# LDR[S]H instructions have not had a -8 bias inserted.
-
-
-# Test the halfword and signextend memory transfers:
-
-.*: +file format .*arm.*
-
-Disassembly of section .text:
-0+00 <[^>]*> e1d100b0 ?        ldrh    r0, \[r1\]
-0+04 <[^>]*> e1f100b0 ?        ldrh    r0, \[r1\]!
-0+08 <[^>]*> e19100b2 ?        ldrh    r0, \[r1, r2\]
-0+0c <[^>]*> e1b100b2 ?        ldrh    r0, \[r1, r2\]!
-0+10 <[^>]*> e1d100bc ?        ldrh    r0, \[r1, #12\]
-0+14 <[^>]*> e1f100bc ?        ldrh    r0, \[r1, #12\]!
-0+18 <[^>]*> e15100bc ?        ldrh    r0, \[r1, #-12\]
-0+1c <[^>]*> e09100b2 ?        ldrh    r0, \[r1\], r2
-0+20 <[^>]*> e3a00cff ?        mov     r0, #65280      ; 0xff00
-0+24 <[^>]*> e1df0abc ?        ldrh    r0, \[pc, #172\]        ; 0+d8 <[^>]*>
-0+28 <[^>]*> e1df0abc ?        ldrh    r0, \[pc, #172\]        ; 0+dc <[^>]*>
-0+2c <[^>]*> e1c100b0 ?        strh    r0, \[r1\]
-0+30 <[^>]*> e1e100b0 ?        strh    r0, \[r1\]!
-0+34 <[^>]*> e18100b2 ?        strh    r0, \[r1, r2\]
-0+38 <[^>]*> e1a100b2 ?        strh    r0, \[r1, r2\]!
-0+3c <[^>]*> e1c100bc ?        strh    r0, \[r1, #12\]
-0+40 <[^>]*> e1e100bc ?        strh    r0, \[r1, #12\]!
-0+44 <[^>]*> e14100bc ?        strh    r0, \[r1, #-12\]
-0+48 <[^>]*> e08100b2 ?        strh    r0, \[r1\], r2
-0+4c <[^>]*> e1cf08b8 ?        strh    r0, \[pc, #136\]        ; 0+dc <[^>]*>
-0+50 <[^>]*> e1d100d0 ?        ldrsb   r0, \[r1\]
-0+54 <[^>]*> e1f100d0 ?        ldrsb   r0, \[r1\]!
-0+58 <[^>]*> e19100d2 ?        ldrsb   r0, \[r1, r2\]
-0+5c <[^>]*> e1b100d2 ?        ldrsb   r0, \[r1, r2\]!
-0+60 <[^>]*> e1d100dc ?        ldrsb   r0, \[r1, #12\]
-0+64 <[^>]*> e1f100dc ?        ldrsb   r0, \[r1, #12\]!
-0+68 <[^>]*> e15100dc ?        ldrsb   r0, \[r1, #-12\]
-0+6c <[^>]*> e09100d2 ?        ldrsb   r0, \[r1\], r2
-0+70 <[^>]*> e3a000de ?        mov     r0, #222        ; 0xde
-0+74 <[^>]*> e1df06d0 ?        ldrsb   r0, \[pc, #96\] ; 0+dc <[^>]*>
-0+78 <[^>]*> e1d100f0 ?        ldrsh   r0, \[r1\]
-0+7c <[^>]*> e1f100f0 ?        ldrsh   r0, \[r1\]!
-0+80 <[^>]*> e19100f2 ?        ldrsh   r0, \[r1, r2\]
-0+84 <[^>]*> e1b100f2 ?        ldrsh   r0, \[r1, r2\]!
-0+88 <[^>]*> e1d100fc ?        ldrsh   r0, \[r1, #12\]
-0+8c <[^>]*> e1f100fc ?        ldrsh   r0, \[r1, #12\]!
-0+90 <[^>]*> e15100fc ?        ldrsh   r0, \[r1, #-12\]
-0+94 <[^>]*> e09100f2 ?        ldrsh   r0, \[r1\], r2
-0+98 <[^>]*> e3a00cff ?        mov     r0, #65280      ; 0xff00
-0+9c <[^>]*> e1df03f4 ?        ldrsh   r0, \[pc, #52\] ; 0+d8 <[^>]*>
-0+a0 <[^>]*> e1df03f4 ?        ldrsh   r0, \[pc, #52\] ; 0+dc <[^>]*>
-0+a4 <[^>]*> e19100b2 ?        ldrh    r0, \[r1, r2\]
-0+a8 <[^>]*> 119100b2 ?        ldrneh  r0, \[r1, r2\]
-0+ac <[^>]*> 819100b2 ?        ldrhih  r0, \[r1, r2\]
-0+b0 <[^>]*> b19100b2 ?        ldrlth  r0, \[r1, r2\]
-0+b4 <[^>]*> e19100f2 ?        ldrsh   r0, \[r1, r2\]
-0+b8 <[^>]*> 119100f2 ?        ldrnesh r0, \[r1, r2\]
-0+bc <[^>]*> 819100f2 ?        ldrhish r0, \[r1, r2\]
-0+c0 <[^>]*> b19100f2 ?        ldrltsh r0, \[r1, r2\]
-0+c4 <[^>]*> e19100d2 ?        ldrsb   r0, \[r1, r2\]
-0+c8 <[^>]*> 119100d2 ?        ldrnesb r0, \[r1, r2\]
-0+cc <[^>]*> 819100d2 ?        ldrhisb r0, \[r1, r2\]
-0+d0 <[^>]*> b19100d2 ?        ldrltsb r0, \[r1, r2\]
-0+d4 <[^>]*> e15f00f4 ?        ldrsh   r0, \[pc, #-4\] ; 0+d8 <[^>]*>
-0+d8 <[^>]*> e15f00f4 ?        ldrsh   r0, \[pc, #-4\] ; 0+dc <[^>]*>
-0+dc <[^>]*> 00000000 ?        andeq   r0, r0, r0
-[              ]*dc:.*fred
-0+e0 <[^>]*> 0000c0de ?        .*
-0+e4 <[^>]*> 0000dead ?        .*
-0+e8 <[^>]*> e1a00000 ?        nop[    ]+\(mov r0,r0\)
-0+ec <[^>]*> e1a00000 ?        nop[    ]+\(mov r0,r0\)

diff --git a/gas/testsuite/gas/arm/wince_copro.d b/gas/testsuite/gas/arm/wince_copro.d
deleted file mode 100644 (file)
index 91097dd..0000000
--- a/gas/testsuite/gas/arm/wince_copro.d
+++ /dev/null
@@ -1,45 +0,0 @@
-#objdump: -dr --prefix-addresses --show-raw-insn --architecture=armv5te
-#name: ARM CoProcessor Instructions (WinCE version)
-#as: -march=armv5te -EL
-#source: copro.s
-
-# This file is the same as copro.d except that the PC-relative
-# LDC and STFS instructions have not had a -8 bias inserted.
-
-# Test the standard ARM co-processor instructions:
-
-.*: +file format .*arm.*
-
-Disassembly of section .text:
-0+000 <[^>]*> ee421103         dvfs    f1, f2, f3
-0+004 <[^>]*> 0e3414a5         cfadddeq        mvd1, mvd4, mvd5
-0+008 <[^>]*> ed939500         cfldr32 mvfx9, \[r3\]
-0+00c <[^>]*> edd1e108         ldfp    f6, \[r1, #32\]
-0+010 <[^>]*> 4db200ff         ldcmi   0, cr0, \[r2, #1020\]!
-0+014 <[^>]*> 5cf31710         ldcpll  7, cr1, \[r3\], #64
-0+018 <[^>]*> ed1f8003         ldc     0, cr8, \[pc, #-12\]
-0+01c <[^>]*> ed830500         cfstr32 mvfx0, \[r3\]
-0+020 <[^>]*> edc0f302         stcl    3, cr15, \[r0, #8\]
-0+024 <[^>]*> 0da2c419         cfstrseq        mvf12, \[r2, #100\]!
-0+028 <[^>]*> 3ca4860c         stccc   6, cr8, \[r4\], #48
-0+02c <[^>]*> ed0f7103         stfs    f7, \[pc, #-12\]
-0+030 <[^>]*> ee715212         mrc     2, 3, r5, cr1, cr2, \{0\}
-0+034 <[^>]*> aeb1f4f2         mrcge   4, 5, pc, cr1, cr2, \{7\}
-0+038 <[^>]*> ee21f711         mcr     7, 1, pc, cr1, cr1, \{0\}
-0+03c <[^>]*> be228519         cfsh64lt        mvdx8, mvdx2, #9
-0+040 <[^>]*> ec907300         ldc     3, cr7, \[r0\], \{0\}
-0+044 <[^>]*> ec816e01         stc     14, cr6, \[r1\], \{1\}
-0+048 <[^>]*> fc925502         ldc2    5, cr5, \[r2\], \{2\}
-0+04c <[^>]*> fc834603         stc2    6, cr4, \[r3\], \{3\}
-0+050 <[^>]*> ecd43704         ldcl    7, cr3, \[r4\], \{4\}
-0+054 <[^>]*> ecc52805         stcl    8, cr2, \[r5\], \{5\}
-0+058 <[^>]*> fcd61906         ldc2l   9, cr1, \[r6\], \{6\}
-0+05c <[^>]*> fcc70a07         stc2l   10, cr0, \[r7\], \{7\}
-0+060 <[^>]*> ecd88bff         ldcl    11, cr8, \[r8\], \{255\}
-0+064 <[^>]*> ecc99cfe         stcl    12, cr9, \[r9\], \{254\}
-0+068 <[^>]*> ec507d04         mrrc    13, 0, r7, r0, cr4
-0+06c <[^>]*> ec407e05         mcrr    14, 0, r7, r0, cr5
-0+070 <[^>]*> ec507fff         mrrc    15, 15, r7, r0, cr15
-0+074 <[^>]*> ec407efe         mcrr    14, 15, r7, r0, cr14
-0+078 <[^>]*> e1a00000         nop                     \(mov r0,r0\)
-0+07c <[^>]*> e1a00000         nop                     \(mov r0,r0\)

diff --git a/gas/testsuite/gas/arm/wince_ldconst.d b/gas/testsuite/gas/arm/wince_ldconst.d
deleted file mode 100644 (file)
index 131b4b5..0000000
--- a/gas/testsuite/gas/arm/wince_ldconst.d
+++ /dev/null
@@ -1,31 +0,0 @@
-#objdump: -dr --prefix-addresses --show-raw-insn
-#name: ARM ldr with immediate constant (WinCE version)
-#as: -mcpu=arm7m -EL
-#source: ldconst.s
-
-# This file is the same as ldconst.d except that the PC-
-# relative LDR instructions have not had a -8 bias inserted.
-
-.*: +file format .*arm.*
-
-Disassembly of section .text:
-0+00 <[^>]*> e3a00000 ?        mov     r0, #0  ; 0x0
-0+04 <[^>]*> e3a004ff ?        mov     r0, #-16777216  ; 0xff000000
-0+08 <[^>]*> e3e00000 ?        mvn     r0, #0  ; 0x0
-0+0c <[^>]*> e51f000c ?        ldr     r0, \[pc, #-12\]        ; 0+08 <[^>]*>
-0+10 <[^>]*> 0fff0000 ?        .*
-0+14 <[^>]*> e3a0e000 ?        mov     lr, #0  ; 0x0
-0+18 <[^>]*> e3a0e8ff ?        mov     lr, #16711680   ; 0xff0000
-0+1c <[^>]*> e3e0e8ff ?        mvn     lr, #16711680   ; 0xff0000
-0+20 <[^>]*> e51fe00c ?        ldr     lr, \[pc, #-12\]        ; 0+1c <[^>]*>
-0+24 <[^>]*> 00fff000 ?        .*
-0+28 <[^>]*> 03a00000 ?        moveq   r0, #0  ; 0x0
-0+2c <[^>]*> 03a00cff ?        moveq   r0, #65280      ; 0xff00
-0+30 <[^>]*> 03e00cff ?        mvneq   r0, #65280      ; 0xff00
-0+34 <[^>]*> 051f000c ?        ldreq   r0, \[pc, #-12\]        ; 0+30 <[^>]*>
-0+38 <[^>]*> 000fff00 ?        .*
-0+3c <[^>]*> 43a0b000 ?        movmi   fp, #0  ; 0x0
-0+40 <[^>]*> 43a0b0ff ?        movmi   fp, #255        ; 0xff
-0+44 <[^>]*> 43e0b0ff ?        mvnmi   fp, #255        ; 0xff
-0+48 <[^>]*> 451fb00c ?        ldrmi   fp, \[pc, #-12\]        ; 0+44 <[^>]*>
-0+4c <[^>]*> 0000fff0 ?        .*