Revert of [release-tools] Fix possible race condition in retrieval of latest rolled...

Reason for revert:
Build slave fetches git repo from cache not from real repo.

Original issue's description:
> [release-tools] Fix possible race condition in retrieval of latest rolled version
>
> R=machenbach@chromium.org
> BUG=
> NOTRY=true
>
> Committed: https://crrev.com/5d2a85b2450f9f88a94949052c5b055c1304b9b8
> Cr-Commit-Position: refs/heads/master@{#29137}

TBR=machenbach@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/1195693003

Cr-Commit-Position: refs/heads/master@{#29140}

diff --git a/tools/release/auto_roll.py b/tools/release/auto_roll.py
index ed2ab21f0fbe4939762468f08826e193aba59f9f..f7692cf6f9775681a9afdb6c13d82c60bb874044 100755 (executable)
--- a/tools/release/auto_roll.py
+++ b/tools/release/auto_roll.py
@@ -48,9 +48,6 @@ class DetectLastRoll(Step):
         max_age=self._options.max_age * DAY_IN_SECONDS)
     assert revisions, "Didn't find any recent release."
 
         max_age=self._options.max_age * DAY_IN_SECONDS)
     assert revisions, "Didn't find any recent release."
 

-    # Update Chromium checkout before DEPS check to fix possible race-condition
-    self.GitPull(cwd=self._options.chromium)
-

     # Interpret the DEPS file to retrieve the v8 revision.
     # TODO(machenbach): This should be part or the roll-deps api of
     # depot_tools.
     # Interpret the DEPS file to retrieve the v8 revision.
     # TODO(machenbach): This should be part or the roll-deps api of
     # depot_tools.

diff --git a/tools/release/test_scripts.py b/tools/release/test_scripts.py
index da4f2d10fc894205c8a82adf0f924dc67184462e..32d0fb837c85f502add80c8c20ab65d6c4bd1c5f 100644 (file)
--- a/tools/release/test_scripts.py
+++ b/tools/release/test_scripts.py
@@ -1112,7 +1112,6 @@ deps = {
       Cmd("git describe --tags bad_tag", ""),
       Cmd("git describe --tags hash_234", "3.22.4"),
       Cmd("git describe --tags hash_123", "3.22.3"),
       Cmd("git describe --tags bad_tag", ""),
       Cmd("git describe --tags hash_234", "3.22.4"),
       Cmd("git describe --tags hash_123", "3.22.3"),

-      Cmd("git pull", "", cwd=TEST_CONFIG["CHROMIUM"]),

       Cmd("git describe --tags abcd123455", "3.22.4"),
       Cmd("git describe --tags hash_234", "3.22.4"),
       Cmd("git describe --tags hash_123", "3.22.3"),
       Cmd("git describe --tags abcd123455", "3.22.4"),
       Cmd("git describe --tags hash_234", "3.22.4"),
       Cmd("git describe --tags hash_123", "3.22.3"),


@@ -1136,7 +1135,6 @@ deps = {
       Cmd("git describe --tags bad_tag", ""),
       Cmd("git describe --tags hash_234", "3.22.4"),
       Cmd("git describe --tags hash_123", "3.22.3"),
       Cmd("git describe --tags bad_tag", ""),
       Cmd("git describe --tags hash_234", "3.22.4"),
       Cmd("git describe --tags hash_123", "3.22.3"),

-      Cmd("git pull", "", cwd=TEST_CONFIG["CHROMIUM"]),

       Cmd("git describe --tags abcd123455", "3.22.3.1"),
       Cmd("git describe --tags hash_234", "3.22.4"),
     ])
       Cmd("git describe --tags abcd123455", "3.22.3.1"),
       Cmd("git describe --tags hash_234", "3.22.4"),
     ])