projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
|
inline
| side by side (parent:
dbc6e7d
)
nilfs2: fix memory leak in nilfs_sysfs_create_##name##_group
author
Nanyong Sun
<sunnanyong@huawei.com>
Wed, 8 Sep 2021 03:00:15 +0000
(20:00 -0700)
committer
Linus Torvalds
<torvalds@linux-foundation.org>
Wed, 8 Sep 2021 18:50:27 +0000
(11:50 -0700)
If kobject_init_and_add return with error, kobject_put() is needed here to
avoid memory leak, because kobject_init_and_add may return error without
freeing the memory associated with the kobject it allocated.
Link:
https://lkml.kernel.org/r/20210629022556.3985106-4-sunnanyong@huawei.com
Link:
https://lkml.kernel.org/r/1625651306-10829-4-git-send-email-konishi.ryusuke@gmail.com
Signed-off-by: Nanyong Sun <sunnanyong@huawei.com>
Signed-off-by: Ryusuke Konishi <konishi.ryusuke@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
fs/nilfs2/sysfs.c
patch
|
blob
|
history
diff --git
a/fs/nilfs2/sysfs.c
b/fs/nilfs2/sysfs.c
index
ec85ac5
..
6305e4e
100644
(file)
--- a/
fs/nilfs2/sysfs.c
+++ b/
fs/nilfs2/sysfs.c
@@
-79,8
+79,8
@@
static int nilfs_sysfs_create_##name##_group(struct the_nilfs *nilfs) \
err = kobject_init_and_add(kobj, &nilfs_##name##_ktype, parent, \
#name); \
if (err) \
err = kobject_init_and_add(kobj, &nilfs_##name##_ktype, parent, \
#name); \
if (err) \
-
return err
; \
- return
0
; \
+
kobject_put(kobj)
; \
+ return
err
; \
} \
static void nilfs_sysfs_delete_##name##_group(struct the_nilfs *nilfs) \
{ \
} \
static void nilfs_sysfs_delete_##name##_group(struct the_nilfs *nilfs) \
{ \