summary |
shortlog |
log |
commit | commitdiff |
tree
raw |
patch |
inline | side by side (from parent 1:
07864d4)
1. Remove std::string copy
2. Remove Property::Array copy
Change-Id: I9b45c0ff87588a6f79d8ae4a109909c7c016dbdf
Signed-off-by: Eunki Hong <eunkiki.hong@samsung.com>
{
case Toolkit::ToggleButton::Property::STATE_VISUALS:
{
{
case Toolkit::ToggleButton::Property::STATE_VISUALS:
{
- Property::Array array = toggleButtonImpl.GetToggleStates();
- value = Property::Value(array);
+ value = toggleButtonImpl.GetToggleStates();
break;
}
case Toolkit::ToggleButton::Property::TOOLTIPS:
break;
}
case Toolkit::ToggleButton::Property::TOOLTIPS:
if(visual)
{
Internal::Visual::Base& visualImpl = Toolkit::GetImplementation(visual);
if(visual)
{
Internal::Visual::Base& visualImpl = Toolkit::GetImplementation(visual);
- return visualImpl.GetPropertyObject(visualPropertyKey);
+ return visualImpl.GetPropertyObject(std::move(visualPropertyKey));
if(accessorIdx >= 0)
{
Dali::Vector<Vector3> bufferData;
if(accessorIdx >= 0)
{
Dali::Vector<Vector3> bufferData;
- LoadDataFromAccessor(accessorIdx, bufferData, path, accessorArray, bufferViewArray, bufferArray);
+ LoadDataFromAccessor(accessorIdx, bufferData, std::move(path), accessorArray, bufferViewArray, bufferArray);
SetMeshInfoAndCanonize(meshInfo, bufferData);
SetMeshInfoAndCanonize(meshInfo, bufferData);
- VertexBuffer vertexBuffer = CreateVertexBuffer<Vector3>(bufferData, map, type);
+ VertexBuffer vertexBuffer = CreateVertexBuffer<Vector3>(bufferData, std::move(map), type);
meshInfo.geometry.AddVertexBuffer(vertexBuffer);
}
}
meshInfo.geometry.AddVertexBuffer(vertexBuffer);
}
}
if(accessorIdx >= 0)
{
Dali::Vector<T> bufferData;
if(accessorIdx >= 0)
{
Dali::Vector<T> bufferData;
- LoadDataFromAccessor(accessorIdx, bufferData, path, accessorArray, bufferViewArray, bufferArray);
+ LoadDataFromAccessor(accessorIdx, bufferData, std::move(path), accessorArray, bufferViewArray, bufferArray);
- VertexBuffer vertexBuffer = CreateVertexBuffer<T>(bufferData, map, type);
+ VertexBuffer vertexBuffer = CreateVertexBuffer<T>(bufferData, std::move(map), type);
meshInfo.geometry.AddVertexBuffer(vertexBuffer);
}
}
meshInfo.geometry.AddVertexBuffer(vertexBuffer);
}
}
void SetIndexBuffersData(MeshInfo& meshInfo, std::string path, std::vector<AccessorInfo>& accessorArray, std::vector<BufferViewInfo>& bufferViewArray, std::vector<BufferInfo>& bufferArray, int32_t indexIdx)
{
Dali::Vector<uint16_t> indexBufferData;
void SetIndexBuffersData(MeshInfo& meshInfo, std::string path, std::vector<AccessorInfo>& accessorArray, std::vector<BufferViewInfo>& bufferViewArray, std::vector<BufferInfo>& bufferArray, int32_t indexIdx)
{
Dali::Vector<uint16_t> indexBufferData;
- LoadDataFromAccessor(indexIdx, indexBufferData, path, accessorArray, bufferViewArray, bufferArray);
+ LoadDataFromAccessor(indexIdx, indexBufferData, std::move(path), accessorArray, bufferViewArray, bufferArray);
meshInfo.geometry.SetIndexBuffer(&indexBufferData[0], indexBufferData.Size());
}
meshInfo.geometry.SetIndexBuffer(&indexBufferData[0], indexBufferData.Size());
}
case Toolkit::ItemView::Property::LAYOUT:
{
case Toolkit::ItemView::Property::LAYOUT:
{
- Property::Array layouts = itemViewImpl.GetLayoutArray();
- value = layouts;
+ value = itemViewImpl.GetLayoutArray();
if(!mContentTextVisual.Empty())
{
Property::Map content = mContentTextVisual; // Need this copy as there's no Value constructor which takes in a 'const Property::Map&'.
if(!mContentTextVisual.Empty())
{
Property::Map content = mContentTextVisual; // Need this copy as there's no Value constructor which takes in a 'const Property::Map&'.
- map.Insert(Toolkit::Tooltip::Property::CONTENT, content);
+ map.Insert(Toolkit::Tooltip::Property::CONTENT, std::move(content));
}
else if(!mContentArray.Empty())
{
Property::Array content = mContentArray; // Need this copy as there's no Value constructor which takes in a 'const Property::Array&'.
}
else if(!mContentArray.Empty())
{
Property::Array content = mContentArray; // Need this copy as there's no Value constructor which takes in a 'const Property::Array&'.
- map.Insert(Toolkit::Tooltip::Property::CONTENT, content);
+ map.Insert(Toolkit::Tooltip::Property::CONTENT, std::move(content));
}
map.Insert(Toolkit::Tooltip::Property::LAYOUT, mLayout);
}
map.Insert(Toolkit::Tooltip::Property::LAYOUT, mLayout);