projects / platform / upstream / gstreamer.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 0194309) | patch
glfilter: Only add parent meta if inbuf != outbuf
authorPiotr Brzeziński <piotr@centricular.com>
Mon, 9 Oct 2023 12:48:35 +0000 (14:48 +0200)
committerTim-Philipp Müller <tim@centricular.com>
Tue, 10 Oct 2023 09:13:15 +0000 (10:13 +0100)
commitb5ca7eba4e3f244074128baceeb8b4c9355907e0
tree92ba01b75c028f5fc85c48b54dc3b4cedf00a866tree | snapshot
parent019430949cdee4b1e8407927789b0c11c53b6a18commit | diff
glfilter: Only add parent meta if inbuf != outbuf

This was causing a memory leak in cases like `gltestsrc ! gltransformation scale-x=0.5 ! glimagesink`.
Parent meta was being added in assumption that those buffers are different, which was not the case here,
creating a reference loop and never freeing the buffer.

Co-authored-by: Matthew Waters <matthew@centricular.com>
Part-of: <https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/5453>
subprojects/gst-plugins-base/gst-libs/gst/gl/gstglfilter.c diff | blob | history
Domain: Multimedia / Media Common;