Rename WebContents related delegate classes inside tizen_src 47/301647/2
authorGajendra N <gajendra.n@samsung.com>
Wed, 24 May 2023 08:32:57 +0000 (14:02 +0530)
committerGajendra N <gajendra.n@samsung.com>
Tue, 21 Nov 2023 07:08:22 +0000 (12:38 +0530)
commitc790c731667df5ec4573a721124f5aa7a7ebebe9
treef7f544af476b1f6921dc04f7927ee3467cc3d07f
parentcbbaf7346ac599c02e4cf893ee2f5773a648ed00
Rename WebContents related delegate classes inside tizen_src

There are around three to four |WebContents**Delegate| classes inside
tizen_src; this causes confusion during debugging the codeflow.

This commit improves readability/understandability by making below changes:
------------------------------------------------------------------------

[1] Rename WebContentsViewDelegateEwk to WebContentsViewDelegateEfl

A class inside tizen_src implementing a opensource public class should have
classname with 'Efl' suffix (instead of 'Ewk').

WebContentsImpl : WebContentsDelegate => WebContentsDelegateEfl
WebContentsViewAura : WebContentsViewDelegate => WebContentsViewDelegateEfl
------------------------------------------------------------------------

[2] Rename WebContentsEflDelegate to WebViewDelegateEfl

Currently WebContentsEflDelegate is created in EWebView and been accessed by
two other classes, hence rename it to WebViewDelegateEfl and make EWebView
own it. Other classes will just use its pointer to route delegate calls.

EWebView                       \
WebContentsImplEfl           ---  WebViewDelegateEfl (owned by EWebView)
WebContentsViewAuraHelperEfl   /
------------------------------------------------------------------------

After this patch, there exists only 2 |WebContents*DelegateEfl| classes, i.e
WebContentsDelegateEfl and WebContentsViewDelegateEfl, both are inherited
from opensource public classes respectively. Other delegate classnames will
not have prefix 'WebContents'.

Change-Id: I5dafc3f858aed6c9affc81d89a3b8512bfcfc6a9
Signed-off-by: Gajendra N <gajendra.n@samsung.com>
17 files changed:
tizen_src/chromium_impl/content/browser/browser_efl.gni
tizen_src/chromium_impl/content/browser/date_time_chooser_efl.cc
tizen_src/chromium_impl/content/browser/screen_orientation/screen_orientation_delegate_efl.cc
tizen_src/chromium_impl/content/browser/selection/selection_controller_efl.cc
tizen_src/chromium_impl/content/browser/web_contents/web_contents_impl_efl.cc
tizen_src/chromium_impl/content/browser/web_contents/web_contents_impl_efl.h
tizen_src/chromium_impl/content/browser/web_contents/web_contents_view_aura_helper_efl.cc
tizen_src/chromium_impl/content/browser/web_contents/web_contents_view_aura_helper_efl.h
tizen_src/chromium_impl/content/public/browser/webview_delegate.h [moved from tizen_src/chromium_impl/content/public/browser/web_contents_efl_delegate.h with 82% similarity]
tizen_src/ewk/efl_integration/BUILD.gn
tizen_src/ewk/efl_integration/content_browser_client_efl.cc
tizen_src/ewk/efl_integration/eweb_view.cc
tizen_src/ewk/efl_integration/eweb_view.h
tizen_src/ewk/efl_integration/web_contents_view_delegate_efl.cc [moved from tizen_src/ewk/efl_integration/web_contents_view_delegate_ewk.cc with 79% similarity]
tizen_src/ewk/efl_integration/web_contents_view_delegate_efl.h [moved from tizen_src/ewk/efl_integration/web_contents_view_delegate_ewk.h with 71% similarity]
tizen_src/ewk/efl_integration/webview_delegate_efl.cc [moved from tizen_src/ewk/efl_integration/web_contents_efl_delegate_ewk.cc with 69% similarity]
tizen_src/ewk/efl_integration/webview_delegate_efl.h [moved from tizen_src/ewk/efl_integration/web_contents_efl_delegate_ewk.h with 71% similarity]