ext4: fix cgroup writeback accounting with fs-layer encryption
authorEric Biggers <ebiggers@google.com>
Fri, 3 Feb 2023 00:55:03 +0000 (16:55 -0800)
committerTheodore Ts'o <tytso@mit.edu>
Wed, 8 Mar 2023 01:12:30 +0000 (20:12 -0500)
commitffec85d53d0f39ee4680a2cf0795255e000e1feb
treee4a79d37b1e49b1f016f71de05553a08213bd5c5
parente3645d72f8865ffe36f9dc811540d40aa3c848d3
ext4: fix cgroup writeback accounting with fs-layer encryption

When writing a page from an encrypted file that is using
filesystem-layer encryption (not inline encryption), ext4 encrypts the
pagecache page into a bounce page, then writes the bounce page.

It also passes the bounce page to wbc_account_cgroup_owner().  That's
incorrect, because the bounce page is a newly allocated temporary page
that doesn't have the memory cgroup of the original pagecache page.
This makes wbc_account_cgroup_owner() not account the I/O to the owner
of the pagecache page as it should.

Fix this by always passing the pagecache page to
wbc_account_cgroup_owner().

Fixes: 001e4a8775f6 ("ext4: implement cgroup writeback support")
Cc: stable@vger.kernel.org
Reported-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Signed-off-by: Eric Biggers <ebiggers@google.com>
Acked-by: Tejun Heo <tj@kernel.org>
Link: https://lore.kernel.org/r/20230203005503.141557-1-ebiggers@kernel.org
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/ext4/page-io.c