m68knommu: fix ucsimm sparse warnings
authorGreg Ungerer <gerg@linux-m68k.org>
Mon, 17 Jan 2022 07:53:51 +0000 (17:53 +1000)
committerGreg Ungerer <gerg@linux-m68k.org>
Mon, 7 Mar 2022 04:51:12 +0000 (14:51 +1000)
commitffe74a6dc9bc47c7c1bb8e9a3d017f6bd5496d76
treeeaafcaf178dcba1ed0a190774bdba166d333a0d9
parent5fb4d4690b77baa8611d7be90e713a9a8faa97e8
m68knommu: fix ucsimm sparse warnings

Sparse reports the following warnings:

  arch/m68k/68000/ucsimm.c:19:15: sparse: sparse: symbol 'cs8900a_hwaddr' was not declared. Should it be static?
  arch/m68k/68000/ucsimm.c:22:1: sparse: sparse: symbol 'getserialnum' was not declared. Should it be static?
  arch/m68k/68000/ucsimm.c:23:1: sparse: sparse: symbol 'gethwaddr' was not declared. Should it be static?
  arch/m68k/68000/ucsimm.c:24:1: sparse: sparse: symbol 'getbenv' was not declared. Should it be static?

'cs8900a_hwaddr' is not used anywhere else in the kernel, so it can be
removed.

All of 'getserialnum', 'gethwaddr' and 'getbenv' are only used in this
file, so they can all be made static. It turns out that these also cause
compiler warnings like this too:

  arch/m68k/68000/ucsimm.c:22:15: warning: no previous prototype for 'getserialnum' [-Wmissing-prototypes]

Also fixed by making them all static.

Signed-off-by: Greg Ungerer <gerg@linux-m68k.org>
Reported-by: kernel test robot <lkp@intel.com>
arch/m68k/68000/ucsimm.c