mm/damon/dbgfs: fix 'struct pid' leaks in 'dbgfs_target_ids_write()'
authorSeongJae Park <sj@kernel.org>
Fri, 31 Dec 2021 04:12:34 +0000 (20:12 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 5 Jan 2022 11:42:39 +0000 (12:42 +0100)
commitffe4a1ba1a82c416a6b3a09d46594f6a885ae141
treee5aeb0d52599508e6d4b61d84e7aae5220efeb7e
parent466267ced87dd514fc0f64e477c3ef5bb881d4f3
mm/damon/dbgfs: fix 'struct pid' leaks in 'dbgfs_target_ids_write()'

commit ebb3f994dd92f8fb4d70c7541091216c1e10cb71 upstream.

DAMON debugfs interface increases the reference counts of 'struct pid's
for targets from the 'target_ids' file write callback
('dbgfs_target_ids_write()'), but decreases the counts only in DAMON
monitoring termination callback ('dbgfs_before_terminate()').

Therefore, when 'target_ids' file is repeatedly written without DAMON
monitoring start/termination, the reference count is not decreased and
therefore memory for the 'struct pid' cannot be freed.  This commit
fixes this issue by decreasing the reference counts when 'target_ids' is
written.

Link: https://lkml.kernel.org/r/20211229124029.23348-1-sj@kernel.org
Fixes: 4bc05954d007 ("mm/damon: implement a debugfs-based user space interface")
Signed-off-by: SeongJae Park <sj@kernel.org>
Cc: <stable@vger.kernel.org> [5.15+]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mm/damon/dbgfs.c