ip_gre: fix IFLA_MTU ignored on NEWLINK
authorXin Long <lucien.xin@gmail.com>
Tue, 27 Feb 2018 11:19:39 +0000 (19:19 +0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 27 Feb 2018 19:36:27 +0000 (14:36 -0500)
commitffc2b6ee417435605ee8bb1eb4c8f02e9ff4b4a5
tree88b7d6734abadeb9777bfc1953becb12eda30807
parent9c2c2e62df3fa30fb13fbeb7512a4eede729383b
ip_gre: fix IFLA_MTU ignored on NEWLINK

It's safe to remove the setting of dev's needed_headroom and mtu in
__gre_tunnel_init, as discussed in [1], ip_tunnel_newlink can do it
properly.

Now Eric noticed that it could cover the mtu value set in do_setlink
when creating a ip_gre dev. It makes IFLA_MTU param not take effect.

So this patch is to remove them to make IFLA_MTU work, as in other
ipv4 tunnels.

  [1]: https://patchwork.ozlabs.org/patch/823504/

Fixes: c54419321455 ("GRE: Refactor GRE tunneling code.")
Reported-by: Eric Garver <e@erig.me>
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv4/ip_gre.c