usb: renesas_usbhs: fix NULL pointer dereference in dma_release_channel()
authorYoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Fri, 30 Jan 2015 06:58:23 +0000 (15:58 +0900)
committerFelipe Balbi <balbi@ti.com>
Fri, 30 Jan 2015 16:35:37 +0000 (10:35 -0600)
commitffb9da65755815611010e07ad1c937858f226cb2
tree45e5c58be6ab7fe6965e700fae0a556b33e30f9d
parent0f4ff5f1f95796ff5e32766136f3d3dfce1ec2d7
usb: renesas_usbhs: fix NULL pointer dereference in dma_release_channel()

This patch fixes an issue that the following commit causes NULL
pointer dereference in dma_release_channel().
 "usb: renesas_usbhs: add support for requesting DT DMA"
 (commit id abd2dbf6bb1b5f3a03a8c76b1a8879da1dd30caa)

The usbhsf_dma_init_dt() should set fifo->{t,r}x_chan to NULL if
dma_request_slave_channel_reason() returns IS_ERR value.
Otherwise, usbhsf_dma_quit() will call dma_release_channel(), and then
NULL pointer dereference happens.

Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>
Tested-by: Simon Horman <horms+renesas@verge.net.au>
Reported-by: Simon Horman <horms@verge.net.au>
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
drivers/usb/renesas_usbhs/fifo.c