net: tun: avoid disabling NAPI twice
authorJakub Kicinski <kuba@kernel.org>
Wed, 29 Jun 2022 18:19:10 +0000 (11:19 -0700)
committerJakub Kicinski <kuba@kernel.org>
Thu, 30 Jun 2022 18:34:10 +0000 (11:34 -0700)
commitff1fa2081d173b01cebe2fbf0a2d0f1cee9ce4b5
tree257bdc6083b6cb0de9b9fb20c4cea6dc724fb60a
parent9c5de246c1dbe785268fc2e83c88624b92e4ec93
net: tun: avoid disabling NAPI twice

Eric reports that syzbot made short work out of my speculative
fix. Indeed when queue gets detached its tfile->tun remains,
so we would try to stop NAPI twice with a detach(), close()
sequence.

Alternative fix would be to move tun_napi_disable() to
tun_detach_all() and let the NAPI run after the queue
has been detached.

Fixes: a8fc8cb5692a ("net: tun: stop NAPI when detaching queues")
Reported-by: syzbot <syzkaller@googlegroups.com>
Reported-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Link: https://lore.kernel.org/r/20220629181911.372047-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/tun.c