Ensure shared_null(s) are statically initialized on VS 2010
authorJoão Abecasis <joao.abecasis@nokia.com>
Wed, 4 Jan 2012 13:30:42 +0000 (14:30 +0100)
committerQt by Nokia <qt-info@nokia.com>
Thu, 5 Jan 2012 12:59:24 +0000 (13:59 +0100)
commitfed603fde515339ec520accefded211ac6f69982
tree914b02ab274db14cc73d2a1ea03d7278e3e8e8f8
parent9a890a519e9e314b99ca765a7127aa8bdc5b8870
Ensure shared_null(s) are statically initialized on VS 2010

This removes const qualification on data members of QConst*Data, which
was subjecting QString's and QByteArray's shared_null to the "order of
static initialization fiasco", with up-to-date VS 2010.

Furthermore, the const qualification in the places where it was removed
had little meaning and no value. It was unnecessary. As such, "Const"
was removed from the struct's names and "Static" used in its place, to
imply their usefulness in supporting statically-initialized fixed-size
(string and byte) containers.

A test case was added to QArrayData as that is meant to replace both
QStringData and QByteArrayData in the near future.

VS issue reported at:
https://connect.microsoft.com/VisualStudio/feedback/details/716461

Change-Id: I3d86f2a387a68f359bb3d8f4d10cf3da51c6ecf7
Reviewed-by: Thiago Macieira <thiago.macieira@intel.com>
Reviewed-by: Olivier Goffart <ogoffart@woboq.com>
Reviewed-by: Bradley T. Hughes <bradley.hughes@nokia.com>
src/corelib/tools/qbytearray.cpp
src/corelib/tools/qbytearray.h
src/corelib/tools/qstring.cpp
src/corelib/tools/qstring.h
src/corelib/tools/qstringbuilder.h
tests/auto/corelib/tools/qarraydata/tst_qarraydata.cpp