sched/rt: Fix RT utilization tracking during policy change
authorVincent Donnefort <vincent.donnefort@arm.com>
Mon, 21 Jun 2021 10:37:51 +0000 (11:37 +0100)
committerPeter Zijlstra <peterz@infradead.org>
Tue, 22 Jun 2021 14:41:59 +0000 (16:41 +0200)
commitfecfcbc288e9f4923f40fd23ca78a6acdc7fdf6c
tree3e31673c76ca64c60d17b456665f96d9f5495043
parent2f064a59a11ff9bc22e52e9678bc601404c7cb34
sched/rt: Fix RT utilization tracking during policy change

RT keeps track of the utilization on a per-rq basis with the structure
avg_rt. This utilization is updated during task_tick_rt(),
put_prev_task_rt() and set_next_task_rt(). However, when the current
running task changes its policy, set_next_task_rt() which would usually
take care of updating the utilization when the rq starts running RT tasks,
will not see a such change, leaving the avg_rt structure outdated. When
that very same task will be dequeued later, put_prev_task_rt() will then
update the utilization, based on a wrong last_update_time, leading to a
huge spike in the RT utilization signal.

The signal would eventually recover from this issue after few ms. Even if
no RT tasks are run, avg_rt is also updated in __update_blocked_others().
But as the CPU capacity depends partly on the avg_rt, this issue has
nonetheless a significant impact on the scheduler.

Fix this issue by ensuring a load update when a running task changes
its policy to RT.

Fixes: 371bf427 ("sched/rt: Add rt_rq utilization tracking")
Signed-off-by: Vincent Donnefort <vincent.donnefort@arm.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>
Link: https://lore.kernel.org/r/1624271872-211872-2-git-send-email-vincent.donnefort@arm.com
kernel/sched/rt.c