tipc: fix a potental access after delete in tipc_sk_join()
authorJon Maloy <jon.maloy@ericsson.com>
Wed, 10 Jan 2018 20:08:50 +0000 (21:08 +0100)
committerDavid S. Miller <davem@davemloft.net>
Mon, 15 Jan 2018 18:43:51 +0000 (13:43 -0500)
commitfebafc8455fdbb0ba53d596075068a683b75f355
treedd63648d661c0f053d2c5c1015fb6cce8e7e9969
parent2c76b34898e5a202f0acbbfb6a228539eb1de9a9
tipc: fix a potental access after delete in tipc_sk_join()

In commit d12d2e12cec2 "tipc: send out join messages as soon as new
member is discovered") we added a call to the function tipc_group_join()
without considering the case that the preceding tipc_sk_publish() might
have failed, and the group item already deleted.

We fix this by returning from tipc_sk_join() directly after the
failed tipc_sk_publish.

Reported-by: syzbot+e3eeae78ea88b8d6d858@syzkaller.appspotmail.com
Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/tipc/socket.c