mptcp: don't orphan ssk in mptcp_close()
authorMenglong Dong <imagedong@tencent.com>
Mon, 28 Nov 2022 15:42:37 +0000 (16:42 +0100)
committerJakub Kicinski <kuba@kernel.org>
Tue, 29 Nov 2022 02:03:07 +0000 (18:03 -0800)
commitfe94800184f22d4778628f1321dce5acb7513d84
treeea41331a6c0bafc6b20fd7688fc1a31270c5766a
parent39f59bca275d2d819a8788c0f962e9e89843efc9
mptcp: don't orphan ssk in mptcp_close()

All of the subflows of a msk will be orphaned in mptcp_close(), which
means the subflows are in DEAD state. After then, DATA_FIN will be sent,
and the other side will response with a DATA_ACK for this DATA_FIN.

However, if the other side still has pending data, the data that received
on these subflows will not be passed to the msk, as they are DEAD and
subflow_data_ready() will not be called in tcp_data_ready(). Therefore,
these data can't be acked, and they will be retransmitted again and again,
until timeout.

Fix this by setting ssk->sk_socket and ssk->sk_wq to 'NULL', instead of
orphaning the subflows in __mptcp_close(), as Paolo suggested.

Fixes: e16163b6e2b7 ("mptcp: refactor shutdown and close")
Reviewed-by: Biao Jiang <benbjiang@tencent.com>
Reviewed-by: Mengen Sun <mengensun@tencent.com>
Signed-off-by: Menglong Dong <imagedong@tencent.com>
Reviewed-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/mptcp/protocol.c