tty/isicom: Fix a possible sleep-in-atomic bug in WaitTillCardIsFree
authorJia-Ju Bai <baijiaju1990@gmail.com>
Tue, 12 Dec 2017 13:24:56 +0000 (21:24 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 15 Dec 2017 19:24:14 +0000 (20:24 +0100)
commitfe8e7acea2426dcd1130fd5c9710b74217c90dd0
tree865a507d64c1ba033fe1d994bd1ee0552d77cb92
parentbe7e251d20e6c800b3b9ee79d1da6059438c34f8
tty/isicom: Fix a possible sleep-in-atomic bug in WaitTillCardIsFree

The driver may sleep under a spinlock.
The function call paths are:
isicom_activate (acquire the spinlock)
  isicom_setup_board
    drop_dtr_rts
      WaitTillCardIsFree
        msleep --> may sleep

isicom_set_termios
  isicom_config_port
    drop_dtr
      WaitTillCardIsFree
        msleep --> may sleep

isicom_tiocmset
  drop_dtr
    WaitTillCardIsFree
      msleep --> may sleep

Though "in_atomic" is used to check atomic context,
but it is not recommended to use in driver code (see include/linux/preempt.h).

To fix it, only using mdelay instead.

This bug is found by my static analysis tool(DSAC) and checked by my code review.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/isicom.c