staging: comedi: ni_mio_common: Use insn->n in ni_calib_insn_write()
authorIan Abbott <abbotti@mev.co.uk>
Tue, 19 Mar 2019 16:54:41 +0000 (16:54 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 20 Mar 2019 07:25:17 +0000 (08:25 +0100)
commitfe57d1e113fcaf6af600c4d10168513c05230160
tree4e3987ef9fa806b6e73b7e6df21c45407c951b5b
parentb8585eb51e74034a7c1dd534a667400b8fd58787
staging: comedi: ni_mio_common: Use insn->n in ni_calib_insn_write()

The `insn_write` handler for the calibration subdevice
(`ni_calib_insn_write()`) currently ignores `insn->n` (the number of
samples to write) and assumes a single sample is to be written, but
`insn->n` could be 0, meaning no samples should be written, in which
case `data[0]` is invalid.

Change `ni_calib_insn_write()` to only write to the calibration device
if `insn->n > 0`.  There isn't much point writing all the values when
`insn->n > 1`, so just write the last one (`data[insn->n - 1]`).

Also follow the usual Comedi convention and return `insn->n` from the
handler to indicate success (although any non-negative return value will
do as far as the Comedi core is concerned).

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/ni_mio_common.c