test: refactor to eliminate flaky test
authorRich Trott <rtrott@gmail.com>
Sat, 29 Aug 2015 02:56:22 +0000 (19:56 -0700)
committerRod Vagg <rod@vagg.org>
Sun, 6 Sep 2015 11:38:59 +0000 (21:38 +1000)
commitfe4b309fd378d2b56a38a3879835ff43cd85fa8f
tree4a63ab31363b72e5718b153e950415a0d78139b8
parent29f586ac0a4e012a9a7838d7dab5c9354fd80c02
test: refactor to eliminate flaky test

This retains the key elements of test-child-process-fork-getconnections
(forks a child process, sends a bunch of sockets, uses getConnections()
to enumerate them) but contains some code to work around an apparent
intermittent bug that occurs on OS X where a socket seems to close
itself unexpectedly.

https://github.com/nodejs/node/issues/2610 was opened for the bug that
was causing the problem in the first place.

PR-URL: https://github.com/nodejs/node/pull/2609
Fixes: https://github.com/nodejs/node/issues/1100
Reviewed-By: jbergstroem - Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Brendan Ashworth <brendan.ashworth@me.com>
test/sequential/sequential.status
test/sequential/test-child-process-fork-getconnections.js